Fix CameraView crash when switching camera on Windows and other CameraView enhancements

samples/CommunityToolkit.Maui.Sample/Pages/Views/CameraView/CameraViewPage.xaml

@@ -10,7 +10,7 @@
                 x:TypeArguments="viewModels:CameraViewViewModel"
                 x:DataType="viewModels:CameraViewViewModel">
 
-    <Grid RowDefinitions="200,*,Auto,Auto" ColumnDefinitions="3*,*">
+    <Grid RowDefinitions="Auto,*,Auto,Auto" ColumnDefinitions="3*,*">
         <toolkit:CameraView
             x:Name="Camera"
             Grid.Column="0" Grid.Row="0" Grid.ColumnSpan="2" Grid.RowSpan="3"
@@ -36,13 +36,13 @@
             </VerticalStackLayout>
         </Grid>
 
-        <ContentView Grid.Column="1" Grid.Row="0" ZIndex="100" BackgroundColor="#80CCCCCC">
+        <Grid Grid.Column="1" Grid.Row="0" ZIndex="100" BackgroundColor="#80CCCCCC">
             <Image x:Name="image" VerticalOptions="Fill" HorizontalOptions="Fill">
                 <Image.GestureRecognizers>
                     <TapGestureRecognizer Tapped="OnImageTapped" />
                 </Image.GestureRecognizers>
             </Image>
-        </ContentView>
+        </Grid>
 
         <Grid ColumnDefinitions="Auto,*,Auto"  Grid.Column="0" Grid.ColumnSpan="2" Grid.Row="2" ColumnSpacing="10" Margin="10"
               BackgroundColor="#00000000">
@@ -61,6 +61,12 @@
 
             <FlexLayout Margin="5" JustifyContent="SpaceBetween" Wrap="Wrap">
 
+                <Picker 
+                    Title="Cameras" 
+                    ItemsSource="{Binding Cameras}"
+                    ItemDisplayBinding="{Binding Name}" 
+                    SelectedItem="{Binding SelectedCamera}" />
+
                 <Picker 
                     Title="Flash"
                     IsVisible="{Binding Path=SelectedCamera.IsFlashSupported, FallbackValue=false}"

samples/CommunityToolkit.Maui.Sample/Pages/Views/CameraView/CameraViewPage.xaml.cs

@@ -27,8 +27,7 @@ protected override async void OnAppearing()
 	{
 		base.OnAppearing();
 
-		var cancellationTokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(3));
-		await BindingContext.RefreshCamerasCommand.ExecuteAsync(cancellationTokenSource.Token);
+		await BindingContext.InitializeAsync();
 	}
 
 	// https://github.com/dotnet/maui/issues/16697
@@ -75,7 +74,7 @@ void OnMediaCaptured(object? sender, MediaCapturedEventArgs e)
 		{
 			// workaround for https://github.com/dotnet/maui/issues/13858
 #if ANDROID
-            image.Source = ImageSource.FromStream(() => File.OpenRead(imagePath));
+			image.Source = ImageSource.FromStream(() => File.OpenRead(imagePath));
 #else
 			image.Source = ImageSource.FromFile(imagePath);
 #endif

samples/CommunityToolkit.Maui.Sample/ViewModels/Views/CameraView/CameraViewViewModel.cs

@@ -9,7 +9,8 @@ public partial class CameraViewViewModel(ICameraProvider cameraProvider) : BaseV
 {
 	readonly ICameraProvider cameraProvider = cameraProvider;
 
-	public IReadOnlyList<CameraInfo> Cameras => cameraProvider.AvailableCameras ?? [];
+	[ObservableProperty]
+	public partial IReadOnlyList<CameraInfo> Cameras { get; set; }
 
 	public CancellationToken Token => CancellationToken.None;
 
@@ -42,6 +43,12 @@ public partial class CameraViewViewModel(ICameraProvider cameraProvider) : BaseV
 	[ObservableProperty]
 	public partial string ResolutionText { get; set; } = string.Empty;
 
+	public async Task InitializeAsync()
+	{
+		await cameraProvider.InitializeAsync;
+		Cameras = cameraProvider.AvailableCameras ?? [];
+	}
+
 	[RelayCommand]
 	async Task RefreshCameras(CancellationToken token) => await cameraProvider.RefreshAvailableCameras(token);
 
@@ -60,6 +67,22 @@ partial void OnSelectedResolutionChanged(Size value)
 		UpdateResolutionText();
 	}
 
+	partial void OnSelectedCameraChanged(CameraInfo? oldValue, CameraInfo? newValue)
+	{
+		UpdateCameraInfoText();
+	}
+
+	void UpdateCameraInfoText()
+	{
+		if (SelectedCamera is null)
+		{
+			return;
+		}
+		CameraNameText = $"{SelectedCamera.Name}";
+		ZoomRangeText = $"Min Zoom: {SelectedCamera.MinimumZoomFactor}, Max Zoom: {SelectedCamera.MaximumZoomFactor}";
+		UpdateFlashModeText();
+	}
+
 	void UpdateFlashModeText()
 	{
 		if (SelectedCamera is null)

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

@@ -130,6 +130,7 @@ protected virtual void Dispose(bool disposing)
 			previewView?.Dispose();
 			previewView = null;
 
+			processCameraProvider?.UnbindAll();
 			processCameraProvider?.Dispose();
 			processCameraProvider = null;
 
@@ -159,16 +160,6 @@ protected virtual async partial Task PlatformConnectCamera(CancellationToken tok
 		{
 			processCameraProvider = (ProcessCameraProvider)(cameraProviderFuture.Get() ?? throw new CameraException($"Unable to retrieve {nameof(ProcessCameraProvider)}"));
 
-			if (cameraProvider.AvailableCameras is null)
-			{
-				await cameraProvider.RefreshAvailableCameras(token);
-
-				if (cameraProvider.AvailableCameras is null)
-				{
-					throw new CameraException("Unable to refresh available cameras");
-				}
-			}
-
 			await StartUseCase(token);
 
 			cameraProviderTCS.SetResult();
@@ -201,22 +192,14 @@ protected async Task StartUseCase(CancellationToken token)
 		await StartCameraPreview(token);
 	}
 
-	protected virtual async partial Task PlatformStartCameraPreview(CancellationToken token)
+	protected virtual partial Task PlatformStartCameraPreview(CancellationToken token)
 	{
 		if (previewView is null || processCameraProvider is null || cameraPreview is null || imageCapture is null)
 		{
-			return;
+			return Task.CompletedTask;
 		}
 
-		if (cameraView.SelectedCamera is null)
-		{
-			if (cameraProvider.AvailableCameras is null)
-			{
-				await cameraProvider.RefreshAvailableCameras(token);
-			}
-
-			cameraView.SelectedCamera = cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
-		}
+		cameraView.SelectedCamera ??= cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
 
 		var cameraSelector = cameraView.SelectedCamera.CameraSelector ?? throw new CameraException($"Unable to retrieve {nameof(CameraSelector)}");
 
@@ -232,6 +215,7 @@ protected virtual async partial Task PlatformStartCameraPreview(CancellationToke
 
 		IsInitialized = true;
 		OnLoaded.Invoke();
+		return Task.CompletedTask;
 	}
 
 	protected virtual partial void PlatformStopCameraPreview()

src/CommunityToolkit.Maui.Camera/CameraManager.macios.cs

@@ -78,24 +78,18 @@
 		captureDevice.UnlockForConfiguration();
 	}
 
-	public async partial ValueTask UpdateCaptureResolution(Size resolution, CancellationToken token)
+	public partial ValueTask UpdateCaptureResolution(Size resolution, CancellationToken token)
 	{
-		if (captureDevice is null)
+		if (captureDevice is null || cameraView.SelectedCamera is null)
 		{
-			return;
+			return ValueTask.CompletedTask;
 		}
 
 		captureDevice.LockForConfiguration(out NSError? error);
 		if (error is not null)
 		{
 			Trace.WriteLine(error);
-			return;
-		}
-
-		if (cameraView.SelectedCamera is null)
-		{
-			await cameraProvider.RefreshAvailableCameras(token);
-			cameraView.SelectedCamera = cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
+			return ValueTask.CompletedTask;
 		}
 
 		var filteredFormatList = cameraView.SelectedCamera.SupportedFormats.Where(f =>
@@ -117,20 +111,11 @@
 		}
 
 		captureDevice.UnlockForConfiguration();
+		return ValueTask.CompletedTask;
 	}
 
 	protected virtual async partial Task PlatformConnectCamera(CancellationToken token)
 	{
-		if (cameraProvider.AvailableCameras is null)
-		{
-			await cameraProvider.RefreshAvailableCameras(token);
-
-			if (cameraProvider.AvailableCameras is null)
-			{
-				throw new CameraException("Unable to refresh cameras");
-			}
-		}
-
 		await PlatformStartCameraPreview(token);
 	}
 
@@ -149,11 +134,7 @@
 			input.Dispose();
 		}
 
-		if (cameraView.SelectedCamera is null)
-		{
-			await cameraProvider.RefreshAvailableCameras(token);
-			cameraView.SelectedCamera = cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
-		}
+		cameraView.SelectedCamera ??= cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
 
 		captureDevice = cameraView.SelectedCamera.CaptureDevice ?? throw new CameraException($"No Camera found");
 		captureInput = new AVCaptureDeviceInput(captureDevice, out _);
@@ -204,7 +185,7 @@
 			var photoOutputConnection = photoOutput.ConnectionFromMediaType(avMediaTypeVideo);
 			if (photoOutputConnection is not null)
 			{
 				photoOutputConnection.VideoOrientation = videoOrientation;
 			}
 		}
 
@@ -271,7 +252,7 @@
 		IEnumerable<UIScene> scenes = UIApplication.SharedApplication.ConnectedScenes;
 		var interfaceOrientation = scenes.FirstOrDefault() is UIWindowScene windowScene
 			? windowScene.InterfaceOrientation
 			: UIApplication.SharedApplication.StatusBarOrientation;
 
 		return interfaceOrientation switch
 		{
@@ -347,7 +328,7 @@
 		{
 			if (PreviewLayer.Connection is not null)
 			{
 				PreviewLayer.Connection.VideoOrientation = videoOrientation;
 			}
 		}
 	}

src/CommunityToolkit.Maui.Camera/CameraManager.windows.cs

@@ -1,7 +1,6 @@
 using System.Runtime.Versioning;
 using CommunityToolkit.Maui.Core.Primitives;
 using CommunityToolkit.Maui.Extensions;
-using Microsoft.Maui.Controls.PlatformConfiguration;
 using Microsoft.UI.Xaml.Controls;
 using Windows.Media.Capture;
 using Windows.Media.Capture.Frames;
@@ -121,16 +120,6 @@ protected virtual void Dispose(bool disposing)
 
 	protected virtual async partial Task PlatformConnectCamera(CancellationToken token)
 	{
-		if (cameraProvider.AvailableCameras is null)
-		{
-			await cameraProvider.RefreshAvailableCameras(token);
-
-			if (cameraProvider.AvailableCameras is null)
-			{
-				throw new CameraException("Unable to refresh cameras");
-			}
-		}
-
 		await StartCameraPreview(token);
 	}
 
@@ -141,13 +130,9 @@ protected virtual async partial Task PlatformStartCameraPreview(CancellationToke
 			return;
 		}
 
-		mediaCapture = new MediaCapture();
+		cameraView.SelectedCamera ??= cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
 
-		if (cameraView.SelectedCamera is null)
-		{
-			await cameraProvider.RefreshAvailableCameras(token);
-			cameraView.SelectedCamera = cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
-		}
+		mediaCapture = new MediaCapture();
 
 		await mediaCapture.InitializeCameraForCameraView(cameraView.SelectedCamera.DeviceId, token);
 
@@ -182,22 +167,22 @@ protected virtual partial void PlatformStopCameraPreview()
 
 	protected async Task PlatformUpdateResolution(Size resolution, CancellationToken token)
 	{
-		if (!IsInitialized || mediaCapture is null)
+		if (!IsInitialized || mediaCapture is null || cameraView.SelectedCamera is null)
 		{
 			return;
 		}
 
-		if (cameraView.SelectedCamera is null)
+		if (mediaCapture.VideoDeviceController.Id != cameraView.SelectedCamera.DeviceId)
 		{
-			await cameraProvider.RefreshAvailableCameras(token);
-			cameraView.SelectedCamera = cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
+			return;
 		}
 
 		var filteredPropertiesList = cameraView.SelectedCamera.ImageEncodingProperties.Where(p => p.Width <= resolution.Width && p.Height <= resolution.Height).ToList();
 
-		filteredPropertiesList = filteredPropertiesList.Count is not 0
-			? filteredPropertiesList
-			: [.. cameraView.SelectedCamera.ImageEncodingProperties.OrderByDescending(p => p.Width * p.Height)];
+		if (filteredPropertiesList.Count is 0)
+		{
+			filteredPropertiesList = [.. cameraView.SelectedCamera.ImageEncodingProperties.OrderByDescending(p => p.Width * p.Height)];
+		}
 
 		if (filteredPropertiesList.Count is not 0)
 		{

src/CommunityToolkit.Maui.Camera/Handlers/CameraViewHandler.shared.cs

@@ -60,7 +60,7 @@
 	}
 
 	/// <inheritdoc/>
 	public void Dispose()
 	{
 		Dispose(true);
 		GC.SuppressFinalize(this);
@@ -90,9 +90,20 @@
 	{
 		base.ConnectHandler(platformView);
 
-		await (cameraManager?.ArePermissionsGranted() ?? Task.CompletedTask);
-		await (cameraManager?.ConnectCamera(CancellationToken.None) ?? Task.CompletedTask);
-		await cameraProvider.RefreshAvailableCameras(CancellationToken.None);
+		if (cameraManager is null)
+		{
+			throw new CameraException("CameraManager is null");
+		}
+
+		if (await cameraManager.ArePermissionsGranted() is false)
+		{
+			throw new PermissionException("Camera permissions not granted");
+		}
+
+		await cameraProvider.InitializeAsync;
+		VirtualView.SelectedCamera ??= cameraProvider.AvailableCameras?.FirstOrDefault() ?? throw new CameraException("No camera available on device");
+
+		await cameraManager.ConnectCamera(CancellationToken.None);
 	}
 
 	/// <inheritdoc/>
@@ -106,7 +117,7 @@
 	/// Releases the unmanaged resources used by the <see cref="CameraViewHandler"/> and optionally releases the managed resources.
 	/// </summary>
 	/// <param name="disposing"><c>true</c> to release both managed and unmanaged resources; <c>false</c> to release only unmanaged resources.</param>
 	protected virtual void Dispose(bool disposing)
 	{
 		if (disposing)
 		{

src/CommunityToolkit.Maui.Camera/Interfaces/ICameraProvider.shared.cs

@@ -11,15 +11,24 @@ public interface ICameraProvider
 	/// Cameras available on device
 	/// </summary>
 	/// <remarks>
-	/// List is initialized using <see cref="RefreshAvailableCameras(CancellationToken)"/>
+	/// List is initialized using <see cref="InitializeAsync"/>, and can be refreshed using <see cref="RefreshAvailableCameras(CancellationToken)"/>
 	/// </remarks>
 	IReadOnlyList<CameraInfo>? AvailableCameras { get; }
 
 	/// <summary>
-	/// Assigns <see cref="AvailableCameras"/> with the cameras available on device
+	/// Refreshes <see cref="AvailableCameras"/> with the cameras available on device
 	/// </summary>
+	/// <remarks>
+	/// Only call this method when the available cameras on device has been updated, as the list is automatically initialized with <see cref="InitializeAsync"/>
+	/// </remarks>
 	/// <param name="token"></param>
 	/// <returns></returns>
 	[MemberNotNull(nameof(AvailableCameras))]
 	ValueTask RefreshAvailableCameras(CancellationToken token);
+
+	/// <summary>
+	/// The <see cref="Task"/> to initialize the available cameras list. This task is automatically started when the <see cref="ICameraProvider"/> is created.
+	/// </summary>
+	Task InitializeAsync { get; }
+
 }

src/CommunityToolkit.Maui.Camera/Providers/CameraProvider.shared.cs

@@ -10,4 +10,13 @@ partial class CameraProvider : ICameraProvider
 
 	/// <inheritdoc/>
 	public partial ValueTask RefreshAvailableCameras(CancellationToken token);
-}
+
+	public CameraProvider()
+	{
+		InitializeAsync = RefreshAvailableCameras(CancellationToken.None).AsTask();
+	}
+
+	/// <inheritdoc/>
+	public Task InitializeAsync { get; init; }
+
+}

src/CommunityToolkit.Maui.Camera/Providers/CameraProvider.windows.cs

@@ -14,12 +14,12 @@ public async partial ValueTask RefreshAvailableCameras(CancellationToken token)
 		var deviceInfoCollection = await DeviceInformation.FindAllAsync(DeviceClass.VideoCapture).AsTask(token);
 		var mediaFrameSourceGroup = await MediaFrameSourceGroup.FindAllAsync().AsTask(token);
 		var videoCaptureSourceGroup = mediaFrameSourceGroup.Where(sourceGroup => deviceInfoCollection.Any(deviceInfo => deviceInfo.Id == sourceGroup.Id)).ToList();
-		var mediaCapture = new MediaCapture();
 
 		var availableCameras = new List<CameraInfo>();
 
 		foreach (var sourceGroup in videoCaptureSourceGroup)
 		{
+			var mediaCapture = new MediaCapture();
 			await mediaCapture.InitializeCameraForCameraView(sourceGroup.Id, token);
 
 			CameraPosition position = CameraPosition.Unknown;
@@ -63,6 +63,8 @@ public async partial ValueTask RefreshAvailableCameras(CancellationToken token)
 				imageEncodingPropertiesList);
 
 			availableCameras.Add(cameraInfo);
+
+			mediaCapture.Dispose();
 		}
 
 		AvailableCameras = availableCameras;