Skip to content

Conversation

@michael-hawker
Copy link
Member

No description provided.

@michael-hawker
Copy link
Member Author

Ah, same error here that I was seeing in #102:

  D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.WPF\CommunityToolkit.Labs.Skia.WPF.csproj : error NU1701: Package 'SkiaSharp.Views.WPF 2.80.3' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln]

@jeromelaban this looks similar to the issue posted here: unoplatform/uno#4036 - is this a regression maybe?

@jeromelaban
Copy link
Collaborator

This is originally a warning that should be ignored. It's the SkiaSharp dependency which is usable for netcore, but is built on net47.

@michael-hawker
Copy link
Member Author

Thanks @jeromelaban, it does build and run fine locally. You said 'originally', so to clarify, should this be something we ignore or is it a concern that it's popped up again?

@jeromelaban
Copy link
Collaborator

@michael-hawker I meant that its "origin" is in the SkiaSharp packages. You should be able to ignore the error by using <NoWarn> msbuild property.

@michael-hawker michael-hawker merged commit 743fab1 into main May 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-uno branch May 12, 2022 22:44
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
* Update Uno to 4.2.6

* Ignore warning on Skia NuGet package, add note about it to props file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants