Skip to content

Conversation

@michael-hawker
Copy link
Member

Fixes #149

We re-write the sample to use an external collection as a developer would in their app. This then properly lets the ItemsControl display just the tokenized items. (Though there's still an issue with how TokenizingTextBox behaves we should resolve.)

PR Type

What kind of change does this PR introduce?

  • Sample app changes

What is the current behavior?

Trying to point to the ItemsSource of the TokenizingTextBox gives us the wrong collection.

What is the new behavior?

We use an external collection (as a developer would bind to their data model) and use that to bind to both the TTB and the ItemsControl. Then it works as intended.

Will open an issue on the main repo for tracking a fix to the underlying TTB.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

We re-write the sample to use an external collection as a developer would in their app. This then properly lets the ItemsControl display just the tokenized items. (Though there's still an issue with how TokenizingTextBox behaves we should resolve.)
@ghost
Copy link

ghost commented Sep 14, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT merged commit 1ca6164 into main Sep 15, 2021
@shweaver-MSFT shweaver-MSFT deleted the fix-peoplepicker-sample branch September 15, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Controls bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled exception in PeoplePicker sample

2 participants