Suppressing some logs from mcp inspector. #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #861 by suppressing verbose logging from HTTP clients used by the MCP Inspector's health checks. The change reduces log noise by filtering out System.Net.Http.HttpClient logs at the LogicalHandler and ClientHandler levels.
- Adds a shared utility for suppressing health check HTTP client logging
- Integrates log suppression into the MCP Inspector resource builder
- Links the shared LoggingUtils.cs file into the MCP Inspector project
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Shared/LoggingUtils.cs | New utility class with method to suppress HTTP client logging for health checks |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs | Adds call to suppress health check logging using the new utility |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/CommunityToolkit.Aspire.Hosting.McpInspector.csproj | Links the shared LoggingUtils.cs file into the project |
Comment on lines
+5
to
+7
|
|
||
| internal static class LoggingUtils | ||
| { |
There was a problem hiding this comment.
The LoggingUtils class and SuppressHealthCheckHttpClientLogging method are missing XML documentation comments. All public members should have XML doc comments according to project guidelines.
Suggested change
| internal static class LoggingUtils | |
| { | |
| /// <summary> | |
| /// Provides utility methods for configuring logging in the application. | |
| /// </summary> | |
| internal static class LoggingUtils | |
| { | |
| /// <summary> | |
| /// Suppresses logging for HTTP client requests made by a specific health check. | |
| /// </summary> | |
| /// <param name="services">The service collection to configure logging for.</param> | |
| /// <param name="healthCheckName">The name of the health check whose HTTP client logging should be suppressed.</param> |
Contributor
Minimum allowed line rate is |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
This was referenced Nov 4, 2025
Merged
This was referenced Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861