-
Notifications
You must be signed in to change notification settings - Fork 131
Fix outdated NodeJS Extensions documentation - update package installation examples to use callback API #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation examples to use callback API instead of array API Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Outdated doc, passing additional args to npm/yarn/Pnpm is no longer an array but an callback instead
Fix outdated NodeJS Extensions documentation - update package installation examples to use callback API
Aug 28, 2025
Copilot finished work on behalf of
aaronpowell
August 28, 2025 00:57
aaronpowell
approved these changes
Aug 28, 2025
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes outdated documentation examples in the NodeJS Extensions README by updating package installation code snippets to use the current callback-based API instead of the deprecated array-based API that was changed in PR #740.
- Updates three package manager examples (npm, yarn, pnpm) to use callback-based configuration
- Replaces old
args: ["..."]syntax with newconfigureInstaller => { configureInstaller.WithArgs("..."); }pattern - Ensures documentation matches the actual implementation and test examples
This was referenced Sep 1, 2025
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation in the NodeJS Extensions README was showing outdated examples for passing additional arguments to package managers during installation. The examples were using the old array-based API that was changed to a callback-based API in PR #740.
Before (incorrect):
After (correct):
Updated all three package manager examples (npm, yarn, and pnpm) in the "Package installation with custom flags" section to use the current callback-based configuration API that matches the actual implementation and test examples.
Fixes #807.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.comdotnet build(dns block)dotnet test --no-build --verbosity normal(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.