-
Couldn't load subscription status.
- Fork 131
Specify the Path of the Golang Executable #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the Path of the Golang Executable #755
Conversation
I enhanced GolangAppHostingExtension to define a new override of AddGolangApp that allows specifying the path of the Golang executable relative to the working directory. This is useful for scenarios where the Golang executable is in a `cmd` subdirectory, but the working directory needs to be the root of the project for accessing resources relative to the working directory at runtime. It is also useful when there are more than one Golang executable in a Go module. Resolves CommunityToolkit#754
|
Thank you for your contribution! I'm currently oof, I'll be back on the 26th, and I'll review this pr asap 🙂 |
@tommasodotNET This PR got closed. Can you re-open it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Closes #754
I enhanced
GolangAppHostingExtensionto define a new override ofAddGolangAppthat allows specifying the path of the Golang executable relative to the working directory. This is useful for scenarios where the Golang executable is in acmdsubdirectory, but the working directory needs to be the root of the project for accessing resources relative to the working directory at runtime. It is also useful when there are more than one executable in a Go module.I updated the existing
AddGolangAppmethod to call the new overload passing.as the executable path. This will support existing consumers without breaking their integrations.PR Checklist
Other information