Specify the Path of the Golang Executable#755
Merged
tommasodotNET merged 2 commits intoCommunityToolkit:mainfrom Jul 28, 2025
Merged
Specify the Path of the Golang Executable#755tommasodotNET merged 2 commits intoCommunityToolkit:mainfrom
tommasodotNET merged 2 commits intoCommunityToolkit:mainfrom
Conversation
I enhanced GolangAppHostingExtension to define a new override of AddGolangApp that allows specifying the path of the Golang executable relative to the working directory. This is useful for scenarios where the Golang executable is in a `cmd` subdirectory, but the working directory needs to be the root of the project for accessing resources relative to the working directory at runtime. It is also useful when there are more than one Golang executable in a Go module. Resolves CommunityToolkit#754
Contributor
|
Thank you for your contribution! I'm currently oof, I'll be back on the 26th, and I'll review this pr asap 🙂 |
Contributor
Author
@tommasodotNET This PR got closed. Can you re-open it? |
This was referenced Aug 4, 2025
Closed
This was referenced Aug 27, 2025
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #754
I enhanced
GolangAppHostingExtensionto define a new override ofAddGolangAppthat allows specifying the path of the Golang executable relative to the working directory. This is useful for scenarios where the Golang executable is in acmdsubdirectory, but the working directory needs to be the root of the project for accessing resources relative to the working directory at runtime. It is also useful when there are more than one executable in a Go module.I updated the existing
AddGolangAppmethod to call the new overload passing.as the executable path. This will support existing consumers without breaking their integrations.PR Checklist
Other information