Use calling assembly for determining build configuration

[sschutten]

Closes #590

This change takes the assembly calling the AddSqlProject extension method for determining the build configuration. The AddSqlProject extension method is usually called from the AppHost project and is used to more reliably determine the build configuration. This works for both during running the AppHost as well as during integration testing.

PR Checklist

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• PR doesn't include merge commits (always rebase on top of our main, if needed)
• New integration
  • Docs are written
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Contains NO breaking changes
• Every new API (including internal ones) has full XML docs
• Code follows all style conventions

Other information

This is my first contribution to this project. Please let me know things I should improve!

[sschutten]

@dotnet-policy-service agree

[jmezach]

@ErikEJ We should have a look at this. We've been going back and forth on what assembly to use for determining the configuration quite a bit. I still think we should use typeof(TProject).Assembly.

[ErikEJ]

@jmezach Not sure why this was needed at all in the first place, tbh

[ErikEJ]

@jmezach And how would you get the assembly from TProject?

[jmezach]

@ErikEJ I believe the main issue was with the CI pipeline of this project itself. The CI was building the referenced MSBuild.Sdk.SqlProj with configuration Release, so when running the tests we couldn't find the .dacpac.

As for how we get the assembly of the TProject, I believe typeof(TProject).Assembly) should just work?

[sschutten]

@jmezach I guess that could work too, for the generic AddSqlProject. But what about the non-generic AddSqlProject, how would that work? Or should there always be a TProject annotation that we could look at?

[ErikEJ]

@sschutten Have you smoke tested the latest change?

[sschutten]

@ErikEJ Yes, all integration tests pass and I can confirm this works in my solution during runtime and during integration tests.

[ErikEJ]

@sschutten OK, I have kicked in the CI build now

[ErikEJ]

I have tested the Nuget package from the CI build on one of our "production" solutions, and it works as expected.

[jmezach]

LGTM