Skip to content

Fixing package versioning - #215

Merged
aaronpowell merged 28 commits into
mainfrom
ci-package-versioning
Nov 11, 2024
Merged

aaronpowell merged 28 commits into
mainfrom
ci-package-versioning

Conversation

@aaronpowell

Copy link
Copy Markdown
Member

Fixes #214

Reused some of the stuff from the life cycle hook (made them static and public).

Should create a new base type like OllamaResourceCommandAnnotation that does a bunch of the setup of setup around when it can be used and connection to OllamaSharp so we can have other hooks like delete/push/etc.
* Disabling ollama integration tests

* Trying to trigger builds
It was waiting for the wrong state (since I changed to using 'Running' not 'Ready' on the model to align with aspire). Added a timeout on the WaitForResource call but I'm unsure it does anything
@aaronpowell
aaronpowell requested a review from Alirexaa November 11, 2024 09:27
@aaronpowell

Copy link
Copy Markdown
Member Author

@CommunityToolkit/aspire-contributors package versioning looks to be fixed with this if someone wants to review and merge then push this up to other branches. I'll clean up NuGet and Azure Pipelines tomorrow (manual task)

@aaronpowell
aaronpowell enabled auto-merge (squash) November 11, 2024 09:38
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 6 ✔
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 100% 100% 28 ✔
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72 ✔
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16 ✔
CommunityToolkit.Aspire.Hosting.Java 98% 71% 58 ✔
CommunityToolkit.Aspire.Hosting.Meilisearch 61% 27% 94 ➖
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 68% 92 ✔
CommunityToolkit.Aspire.Hosting.Ollama 64% 57% 222 ➖
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 69% 60% 50 ➖
CommunityToolkit.Aspire.Meilisearch 97% 92% 68 ✔
CommunityToolkit.Aspire.OllamaSharp 84% 77% 76 ✔
Summary 77% (1558 / 2018) 62% (374 / 600) 782 ➖

Minimum allowed line rate is 60%

This branch was previously deployed

1 inactive deployment
azure-artifacts — d81eb11c Deployed Nov 11, 2024 by aaronpowell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NuGet package versioning broken in PR and main

2 participants