-
Notifications
You must be signed in to change notification settings - Fork 158
Java hosting integration enhancements & Gradle support #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marshalhayes
wants to merge
15
commits into
CommunityToolkit:main
Choose a base branch
from
marshalhayes:gradle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+707
−370
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c7ada4d
Start adding gradle support
marshalhayes 37000e0
Refactor the Java hosting integration to allow Aspire to manage the e…
marshalhayes 03aab8e
Refactor to reduce the number of potential breaking changes
marshalhayes f1d3c9a
Refine Java hosting integration APIs and documentation
marshalhayes 0455f50
Add WithJarPath, WithMavenGoal, WithGradleTask and new AddJavaApp ove…
marshalhayes 8aec70f
Remove auto-generated Dockerfile logic and fix review issues
marshalhayes 17ca479
Fix trailing double quotes and extra blank lines in XML docs
marshalhayes c642e5e
Rename JAVA_TOOL_OPTIONS constant to PascalCase
marshalhayes 48f36c0
Pass wrapperScript to build resource constructors instead of overridi…
marshalhayes d04fdea
Replace WithOtelAgent() with WithOtlpExporter() in new methods
marshalhayes dd9e699
Make JarPath nullable with no default
marshalhayes 90105f1
Disallow use of jar path when using WithMavenGoal/WithGradleTask
marshalhayes 94a44cc
Remove BeforeStartEvent subscription for command override
marshalhayes 9bd8761
Improve Java hosting API correctness and compat
marshalhayes 9d4c9a1
Replace Microsoft Learn link with aspire.dev
marshalhayes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/CommunityToolkit.Aspire.Hosting.Java/GradleBuildResource.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
||
| /// <summary> | ||
| /// A resource that represents a Gradle build step. | ||
| /// </summary> | ||
| /// <param name="name">The name of the resource.</param> | ||
| /// <param name="wrapperScript">The full path to the Gradle wrapper script.</param> | ||
| /// <param name="workingDirectory">The working directory to use for the command.</param> | ||
| public class GradleBuildResource(string name, string wrapperScript, string workingDirectory) | ||
| : ExecutableResource(name, wrapperScript, workingDirectory); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.