-
Notifications
You must be signed in to change notification settings - Fork 154
Bump flagd version and add telemetry support #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the flagd feature flag integration to use the latest container image version (v0.13.1) and adds built-in telemetry support through OTLP exporter configuration.
Key changes:
- Bumped the flagd container image from v0.12.9 to v0.13.1 to leverage the latest features and fixes
- Added
.WithOtlpExporter()to enable OpenTelemetry integration out-of-the-box, following the established pattern used across other integrations in the toolkit
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Flagd/FlagdContainerImageTags.cs | Updated container image tag constant and XML documentation from v0.12.9 to v0.13.1 |
| src/CommunityToolkit.Aspire.Hosting.Flagd/FlagdBuilderExtensions.cs | Added .WithOtlpExporter() call in the AddFlagd method to enable OTLP telemetry exporter support |
| tests/CommunityToolkit.Aspire.Hosting.Flagd.Tests/AddFlagdTests.cs | Updated test assertion to expect the new v0.13.1 container image tag |
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
This pull request updates the
flagdresource integration to use a newer container image version and adds support for OTLP exporter configuration. It also ensures the related tests reflect the image version change.Container image update:
flagdcontainer image tag fromv0.12.9tov0.13.1inFlagdContainerImageTagsand corresponding test assertions to ensure the latest features and fixes are used. [1] [2]Feature enhancement:
.WithOtlpExporter()to theAddFlagdresource builder, enabling OTLP exporter support for telemetry out of the box.PR Checklist
Other information
This is just a bump on the flagd container. It doesn't bring any breaking changes.