[BUG] SQL Projects publishing broken in 9.1 with 9.2 hosting extension

[ErikEJ]

Describe the bug

SQL Server Database project package not found at path C:\Code\xxx\bin\Release\netstandard2.1\Workflow.Database.dacpac.

Regression

9.0.0

Steps to reproduce

Run any sample with a number of SQL Projects

Expected behavior

My VS is running in Debug mode, so the extension should look for files in the Debug folder.

@aaronpowell Could this be your recent change here?

https://github.com/CommunityToolkit/Aspire/blame/main/src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectResource.cs#L20

Screenshots

No response

IDE and version

VS 2022

IDE version

17.13

Nuget packages

<PackageVersion Include="Aspire.Hosting.AppHost" Version="9.1.0" />
    <PackageVersion Include="CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects" Version="9.2.0" />

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item

[aaronpowell]

hmm my guess is that's where the problem is, but I'd have assumed that attribute was there if it is in debug mode still.

[ErikEJ]

@jmezach FYI 😳

[jmezach]

@ErikEJ Are the samples in this repo working? We use those in CI as well, so we should have seen it if we broke something right?

[ErikEJ]

@jmezach The latest main sample is working fine - I will dive a bit deeper on our solution

[ErikEJ]

@jmezach @aaronpowell

I have a repro now that is a "production app" not a sample in this repo!

https://github.com/ErikEJ/AspireEndToEnd

Open solution in Visual Studio.

Main branch is working fine.

check out the ninetwo branch - broken - looking for .dacpac in wrong folder

in ninetwo branc, revert the SQL projects package to 9.1.0 - working again 😢

I think this must be reverted!

https://github.com/CommunityToolkit/Aspire/blame/35e3911da0db92594aae091a188543a998437ed1/src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectResource.cs#L20

[jmezach]

Looking at that code again I think it is getting the assembly configuration attribute from our own assembly. We should probably get it from the IProjectMetadata type that is provided, since that is in the AppHost project of the user.

[ErikEJ]

@jmezach that also explains why the sample project works I guess

[jmezach]

Yeah, because those are always build with the same configuration.

[ErikEJ]

@aaronpowell @jmezach I am able to repro on the sample project if I make this change to it (slightly more complex in real life due to central package management)

<PackageReference Include="CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects" Version="9.2.0" />

[ErikEJ]

We should probably get it from the IProjectMetadata type that is provided

Is that even possible - I think the correct fix is to revert the recent change

[jmezach]

I think we can do projectMetadata.GetType().GetCustomAttribute...

[ErikEJ]

I am not sure

https://learn.microsoft.com/en-us/dotnet/api/aspire.hosting.iprojectmetadata?view=dotnet-aspire-8.0

[jmezach]

The interface is defined in Aspire, but the implementation is generated at build time and compiled into the AppHost assembly