refactor(signer): Use config-based header to extract IP from#388
Merged
ManuelBilbao merged 8 commits intosigp-audit-fixesfrom Oct 21, 2025
Merged
refactor(signer): Use config-based header to extract IP from#388ManuelBilbao merged 8 commits intosigp-audit-fixesfrom
ManuelBilbao merged 8 commits intosigp-audit-fixesfrom
Conversation
jclapis
requested changes
Oct 13, 2025
jclapis
approved these changes
Oct 21, 2025
Collaborator
jclapis
left a comment
jclapis
left a comment
There was a problem hiding this comment.
A few documentation amendment suggestions, but they aren't crucial if they're going to block merging.
Co-authored-by: Joe Clapis <jclapis@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a config param to set the trusted HTTP header to get the user's IP from