Fix misc findings from reaudit#376
Merged
jclapis merged 13 commits intosigp-audit-fixesfrom Sep 30, 2025
Merged
Conversation
ManuelBilbao
approved these changes
Sep 22, 2025
ltitanb
requested changes
Sep 30, 2025
crates/signer/src/service.rs
Outdated
Comment on lines
98
to
100
| jwts: Arc::new(RwLock::new(config.mod_signing_configs)), | ||
| admin_secret: Arc::new(RwLock::new(config.admin_secret)), | ||
| jwt_auth_failures: Arc::new(RwLock::new(HashMap::new())), |
Collaborator
There was a problem hiding this comment.
i dont think we should use tokio RwLock here, in general I'd much rather take a guard lock twice than hold it for long
Collaborator
Author
There was a problem hiding this comment.
Discussed offline and reverted in a29a366 due to performance reasons.
Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>
This reverts commit a9e2479.
ltitanb
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work In Progress
This fixes several smaller miscellaneous findings from the reaudit assessment.
CBST2-01
CBST2-04
handle_reload()now updates the state atomically once all of the code has succeeded, and doesn't update it at all if any failures occur.CBST2-06
Fixed a race that occurred due to differing locks on JWT auth failure reads and writes.This was reverted due to performance considerations with locking the auth check for each request.CBST2-14