Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR parallelizes key loading by leveraging Rayon for concurrent decryption and updates dependency versions and workspace settings.
- Added
rayonandjsonwebtokenas workspace dependencies in signer and common crates - Refactored
load_from_*functions to collect directory entries and decrypt in parallel - Updated
eth2_keystoredependency in rootCargo.tomlto use a Git tag instead of a specific revision
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/signer/Cargo.toml | Added jsonwebtoken workspace entry |
| crates/common/src/signer/loader.rs | Refactored sequential loops to parallel iterations with Rayon |
| crates/common/Cargo.toml | Added jsonwebtoken and rayon workspace entries |
| Cargo.toml | Changed eth2_keystore from a git revision to a git tag and added rayon dependency |
Comments suppressed due to low confidence (2)
crates/common/src/signer/loader.rs:112
- Parallel loading paths introduce concurrency concerns. Add unit or integration tests to verify correct behavior across different directory structures and error cases.
fn load_from_lighthouse_format(
Cargo.toml:39
- Pinning to a moving Git tag can undermine reproducible builds. Consider using a specific commit SHA for deterministic dependency resolution.
eth2_keystore = { git = "https://github.com/sigp/lighthouse", tag = "v7.0.1" }
jclapis
requested changes
Jul 7, 2025
jclapis
approved these changes
Jul 7, 2025
ManuelBilbao
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
speed up keys loading at startup by parallezing decryption across cores