Skip to content

Commit

Permalink
[services] Allow browsers to access prod identity from comm.software
Browse files Browse the repository at this point in the history
Summary:
This diff updates the CORS config for the identity service in production to allow incoming connections from browsers rendering comm.software and www.comm.software.

Context for why we need this is in [ENG-9862](https://linear.app/comm/issue/ENG-9862/investigate-performance-issues-when-threadstore-changes).

Test Plan: Terraform precommit hooks passed. Beyond that, not sure how to test this besides deploying to prod...

Reviewers: varun, will, bartek

Reviewed By: varun

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13881
  • Loading branch information
Ashoat committed Nov 5, 2024
1 parent 95b6459 commit ebc9cb1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion services/terraform/remote/service_identity.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ locals {
http://localhost:3008,
http://localhost:3009
EOT
production_allow_origin_list = "https://web.comm.app"
production_allow_origin_list = <<EOT
https://web.comm.app,
https://comm.software:443,
https://www.comm.software:443
EOT
}

data "aws_secretsmanager_secret" "identity_server_setup" {
Expand Down

0 comments on commit ebc9cb1

Please sign in to comment.