Skip to content

Commit

Permalink
[native] Fix bitcode issue with Xcode 14
Browse files Browse the repository at this point in the history
Summary:
Addresses [ENG-1938](https://linear.app/comm/issue/ENG-1938/ashoat-cant-locally-build-ios-release-build-for-version-145-targeting). Learned more about this issue [here](facebook/react-native#34148 (comment)).

This diff effectively reverts D30. Back then, the default was `ENABLE_BITCODE = YES`, and that diff had the effect of disabling bitcode for debug builds. Now that `ENABLE_BITCODE = NO` is the default, that diff has the effect of enabling bitcode for release builds.

Deleting these lines puts us back to "default" behavior, which is now to have bitcode disabled.

Test Plan: Issue no longer occurs after `yarn workspace native clean-all && yarn cleaninstall`

Reviewers: atul

Reviewed By: atul

Subscribers: tomek, abosh

Differential Revision: https://phab.comm.dev/D5277
  • Loading branch information
Ashoat committed Oct 3, 2022
1 parent 4bd5734 commit 38328bf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions native/ios/Comm.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,6 @@
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
DEVELOPMENT_TEAM = H98Y8MH53M;
ENABLE_BITCODE = NO;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
GCC_PREPROCESSOR_DEFINITIONS = (
"$(inherited)",
Expand Down Expand Up @@ -1266,7 +1265,6 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = H98Y8MH53M;
ENABLE_BITCODE = YES;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
HEADER_SEARCH_PATHS = (
"$(inherited)",
Expand Down

0 comments on commit 38328bf

Please sign in to comment.