Skip to content

Conversation

@webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 11, 2025

Guards against exception. Repro:

  1. Change from default window style to custom via setWindowStyle
  2. Send any window controls theme update (change button size / colour)
  3. Throws

Solution

AppWindow now checks the settings it was created with, rather than the current settings.

Cause

Original frontend impl. was incomplete (settings), so the flaw went unnoticed.

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner January 11, 2025 10:40
@huchenlei huchenlei merged commit 28c1ca7 into main Jan 12, 2025
7 checks passed
@huchenlei huchenlei deleted the fix-crash-on-change branch January 12, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants