Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 16, 2026

yarn typescript did not check the tests folder before. This PR aims to resolve that.

Summary

  • add typecheck, typecheck:build, and typecheck:tests scripts
  • keep build-only typechecks for Vite compile/type flows
  • add tsconfig.tests.json and update docs

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested review from a team as code owners January 16, 2026 22:53
Copilot AI review requested due to automatic review settings January 16, 2026 22:53
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

This pull request refactors TypeScript type-checking configuration into three separate scripts (typecheck, typecheck:build, typecheck:tests) targeting different contexts, along with a new test-specific TypeScript configuration file. Documentation and build orchestration are updated to reference the new setup.

Changes

Cohort / File(s) Summary
Documentation Updates
AGENTS.md
Updated development workflow documentation to reflect renamed TypeScript type-check command from yarn typescript to yarn typecheck, with clarification for "TypeScript type checking (all)". Updated "Before Committing" step to use new lint/typecheck command.
Build Script Reorganization
package.json
Replaced single typescript script with three specialized type-check scripts: typecheck (all files), typecheck:build (build files), and typecheck:tests (test files). Updated vite:compile and vite:types to use typecheck:build instead of typescript.
TypeScript Configuration
tsconfig.tests.json
Added new configuration file extending base tsconfig.json with explicit test file inclusions (tests/**/\*, playwright.config.ts, playwright.setup.ts) to isolate test compilation settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds separate TypeScript typecheck scripts to provide more granular control over type checking for different parts of the codebase. It introduces three new npm scripts (typecheck, typecheck:build, typecheck:tests) to replace the single typescript script, and creates a new tsconfig.tests.json configuration for testing-related files.

Changes:

  • Adds three typecheck scripts: typecheck (all), typecheck:build (build only), typecheck:tests (tests only)
  • Creates tsconfig.tests.json extending the base config to specifically include test files
  • Updates AGENTS.md documentation to reflect the new command name

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tsconfig.tests.json New TypeScript config for test files, including tests directory and Playwright config files
package.json Replaces typescript script with three granular typecheck scripts; updates build scripts to use typecheck:build
AGENTS.md Updates documentation references from yarn typescript to yarn typecheck

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,4 @@
{
"extends": "./tsconfig.json",
"include": ["tests/**/*", "playwright.config.ts", "playwright.setup.ts"]
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsconfig.tests.json includes test files that are already covered by the base tsconfig.json's include patterns (which includes 'tests/**/*'). This creates redundancy since running 'tsc -p tsconfig.json' will already typecheck these files. Consider whether tsconfig.tests.json should exclude non-test files to provide true isolation, or clarify the intended purpose of having separate test typechecking if it's meant to run with different compiler options in the future.

Copilot uses AI. Check for mistakes.
@benceruleanlu benceruleanlu marked this pull request as draft January 16, 2026 22:56
@benceruleanlu benceruleanlu marked this pull request as ready for review January 16, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants