-
Notifications
You must be signed in to change notification settings - Fork 178
Add split typecheck scripts for build and tests #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request refactors TypeScript type-checking configuration into three separate scripts ( Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds separate TypeScript typecheck scripts to provide more granular control over type checking for different parts of the codebase. It introduces three new npm scripts (typecheck, typecheck:build, typecheck:tests) to replace the single typescript script, and creates a new tsconfig.tests.json configuration for testing-related files.
Changes:
- Adds three typecheck scripts:
typecheck(all),typecheck:build(build only),typecheck:tests(tests only) - Creates
tsconfig.tests.jsonextending the base config to specifically include test files - Updates AGENTS.md documentation to reflect the new command name
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsconfig.tests.json | New TypeScript config for test files, including tests directory and Playwright config files |
| package.json | Replaces typescript script with three granular typecheck scripts; updates build scripts to use typecheck:build |
| AGENTS.md | Updates documentation references from yarn typescript to yarn typecheck |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
| "include": ["tests/**/*", "playwright.config.ts", "playwright.setup.ts"] | |||
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tsconfig.tests.json includes test files that are already covered by the base tsconfig.json's include patterns (which includes 'tests/**/*'). This creates redundancy since running 'tsc -p tsconfig.json' will already typecheck these files. Consider whether tsconfig.tests.json should exclude non-test files to provide true isolation, or clarify the intended purpose of having separate test typechecking if it's meant to run with different compiler options in the future.
yarn typescript did not check the tests folder before. This PR aims to resolve that.
Summary
typecheck,typecheck:build, andtypecheck:testsscriptstsconfig.tests.jsonand update docs┆Issue is synchronized with this Notion page by Unito