Adding c10d ops and additional aten ops for DTensor and FSDP2#29
Open
komikndr wants to merge 8 commits intoComfy-Org:mainfrom
Open
Adding c10d ops and additional aten ops for DTensor and FSDP2#29komikndr wants to merge 8 commits intoComfy-Org:mainfrom
komikndr wants to merge 8 commits intoComfy-Org:mainfrom
Conversation
Now it implement in classmethod, more cleaner, and NVFP4 can implement it down the line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary pull request adding FP8 operators to support Raylight custom nodes.
The c10d operators will not be touched during a normal Comfy run, sincen as far as I know only Raylight uses DTensor and its operators, which require an initialized distributed process group. Normal
ComfyUI/main.pyexecution does not initialize this.The operators being added:
c10d
all_gather_into_tensorbroadcast_wait_tensorscatter_aten
slicesplitnew_zerosas_stridedcataliasIn practice, for c10d only
all_gather_into_tensorandwait_tensorare currently required, sincewait_tensoris needed for the FSDP unshard path where an in-place copy cannot directly transfer aQuantizedTensorinto an unquantized tensor.To use this inside a model, the
nn.Modulecannot inherit from a "disable init weight" operator, since every sharded parameter must be properly accounted for.