Closed
Conversation
…ject config for better resource accessibility
… specify dependency version requirement
…uires-comfyui version constraint for better understanding
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…tadata and compatibility information
Collaborator
|
Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see Comfy-Org/ComfyUI#8357 |
robinjhuang
reviewed
Jun 6, 2025
robinjhuang
reviewed
Jun 6, 2025
robinjhuang
reviewed
Jun 6, 2025
Co-authored-by: Robin Huang <robin.j.huang@gmail.com>
Member
|
@snomiao Is this ready for review again? |
… comment for requires-comfyui for better readability and maintainability
…y-cli into sno-update-specifications
Member
Author
Hey @robinjhuang, sorry for late reply, it's ready for review again now :D |
snomiao
added a commit
that referenced
this pull request
Jul 6, 2025
* feat(config_parser.py): add comments for ComfyUI version compatibility and project classifiers to improve documentation and usability chore(config_parser.py): enhance project URLs by adding Documentation and Bug Tracker links for better project navigation * Update comfy_cli/registry/config_parser.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
robinjhuang
approved these changes
Jul 26, 2025
Contributor
|
@snomiao I guess we can close this PR since the PR that replaces it was merged 3 weeks ago? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect latest specification.
see also - Update pyproject specifications ver2 #281 by snomiao · Pull Request #285 · Comfy-Org/comfy-cli
Will generate a pyproject.toml like this
Notion Context:
https://www.notion.so/drip-art/Use-compatibility-fields-conflict-resolution-UI-UX-2086d73d3650804e901fef5b511eb411
Note: comfy-cli is used by ComfyPR when creating new PRs