Send additional metadata to registry service during node creation#279
Merged
robinjhuang merged 4 commits intomainfrom Jun 8, 2025
Merged
Send additional metadata to registry service during node creation#279robinjhuang merged 4 commits intomainfrom
robinjhuang merged 4 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
47a9563 to
7c2cdaf
Compare
7c2cdaf to
2e36f33
Compare
92199a0 to
137bbb6
Compare
Collaborator
|
Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see Comfy-Org/ComfyUI#8357 |
a249961 to
e54cb2c
Compare
e54cb2c to
401d252
Compare
0cd975c to
5715763
Compare
Member
|
LGTM. Good to merge after confirming that this was testing publishing to staging. |
6aeace3 to
26ad1b0
Compare
Contributor
Author
|
Tested with latest staging changes: pyproject.toml file: |
26ad1b0 to
c4370bc
Compare
robinjhuang
approved these changes
Jun 8, 2025
Collaborator
|
@coderfromthenorth93 @robinjhuang do you think we need to add supported_comfyui_manager_version as metadata? because I know some custom nodes are using the api of ComfyUI Manager? |
Collaborator
|
BTW as I mentioned, for any new metadata in types, it should be synced to Core types https://github.com/comfyanonymous/ComfyUI/blob/master/comfy_config/types.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the toml file and send the following fields from pyproject.toml to backend when publishing a node:
supported_os- extracted from fields which have aOperation System ::prefix in classifierssupported_accelerators- extracted from fields which have aEnvironment ::prefix in classifierssupported_comfyui_version- extracted fromrequires-comfyuitoolssupported_comfyui_frontend_version- extracted fromcomfyui-frontend-packageindependencies(this is stripped fromdependenciesarray which is sent to the registryResolves #273