Fix routing and layout issue #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
approved these changes
Sep 22, 2024
src/App.vue
Outdated
| api.removeEventListener('reconnected', onReconnected) | ||
| executionStore.unbindExecutionEvents() | ||
| }) | ||
| onBeforeUnmount(() => {}) |
There was a problem hiding this comment.
nit: Remove the empty callback
|
@dmx974 BTW can you merge this to dev1.3 to avoid further merge conflict on dev1.3? |
|
playwright-tests-chromium passed on main, but not on dev1.3, I didn't use dev1.3 as base branch, can you merge that PR on main? |
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
This reverts commit 94db2e9.
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
huchenlei
pushed a commit
that referenced
this pull request
Sep 23, 2024
* fix router and move graph related parts to GraphView.vue * (fix) add back child element in UnloadWindowConfirmDialog * (cleanup) remove empty callback
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
huchenlei
pushed a commit
that referenced
this pull request
Sep 24, 2024
* fix router and move graph related parts to GraphView.vue * (fix) add back child element in UnloadWindowConfirmDialog * (cleanup) remove empty callback
huchenlei
added a commit
that referenced
this pull request
Sep 24, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 24, 2024
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix router and move graph related parts to GraphView.vue * (fix) add back child element in UnloadWindowConfirmDialog * (cleanup) remove empty callback
huchenlei
added a commit
that referenced
this pull request
Sep 25, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 25, 2024
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix router and move graph related parts to GraphView.vue * (fix) add back child element in UnloadWindowConfirmDialog * (cleanup) remove empty callback
huchenlei
added a commit
that referenced
this pull request
Sep 25, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some graph-related logic from App.vue to GraphView.vue to prevent execution with other routes.
That basically make layout management and client-side routing work as expected (for instance, you can now go to /test without issues).