Skip to content

[backport core/1.39] fix: resolve ImageCrop input image through subgraph nodes#8946

Merged
pythongosssss merged 1 commit intocore/1.39from
backport-8899-to-core-1.39
Feb 18, 2026
Merged

[backport core/1.39] fix: resolve ImageCrop input image through subgraph nodes#8946
pythongosssss merged 1 commit intocore/1.39from
backport-8899-to-core-1.39

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Feb 18, 2026

Backport of #8899 to core/1.39

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary
When ImageCrop's input comes from a subgraph node, getInputNode returns
the subgraph node itself which has no image outputs.
Use resolveSubgraphOutputLink to trace through to the actual source node
(e.g. LoadImage) inside the subgraph.

Use canvas.graph (the currently active graph/subgraph) as the primary
lookup, falling back to rootGraph. When the ImageCrop node is inside a
subgraph, rootGraph cannot find it since it only contains root-level
nodes.

## Screenshots (if applicable)
before


https://github.com/user-attachments/assets/c3995f7c-6bcd-41fe-bc41-cfd87f9be94a


after


https://github.com/user-attachments/assets/ac660f58-6e6a-46ad-a441-84c7b88d28e2

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8899-fix-resolve-ImageCrop-input-image-through-subgraph-nodes-3086d73d36508172a759d7747190591f)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 18, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner February 18, 2026 00:56
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 18, 2026
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-8899-to-core-1.39

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Playwright: ✅ 525 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 513 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 02/18/2026, 12:58:08 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@pythongosssss pythongosssss merged commit a0b1fcd into core/1.39 Feb 18, 2026
38 checks passed
@pythongosssss pythongosssss deleted the backport-8899-to-core-1.39 branch February 18, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants