Skip to content

[backport cloud/1.39] feat: gate node replacement loading on server feature flag#8941

Merged
christian-byrne merged 1 commit intocloud/1.39from
backport-8750-to-cloud-1.39
Feb 17, 2026
Merged

[backport cloud/1.39] feat: gate node replacement loading on server feature flag#8941
christian-byrne merged 1 commit intocloud/1.39from
backport-8750-to-cloud-1.39

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Feb 17, 2026

Backport of #8750 to cloud/1.39

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary

Gates the node replacement store's `load()` call behind the
`node_replacements` server feature flag, so the frontend only calls
`/api/node_replacements` when the backend advertises support.

## Changes

- Added `NODE_REPLACEMENTS = 'node_replacements'` to `ServerFeatureFlag`
enum
- Added `nodeReplacementsEnabled` getter to `useFeatureFlags()`
- Added `api.serverSupportsFeature('node_replacements')` guard in
`useNodeReplacementStore.load()`

## Context

Without this guard, the frontend would attempt to fetch node
replacements from backends that don't support the endpoint, causing 404
errors.

Companion backend PR: Comfy-Org/ComfyUI#12362

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8750-feat-gate-node-replacement-loading-on-server-feature-flag-3026d73d365081ec9246d77ad88f5bdc)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Jin Yi <jin12cc@gmail.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 17, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner February 17, 2026 19:43
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 17, 2026
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 17, 2026
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 02/17/2026, 07:45:12 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Playwright: ✅ 519 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 507 / ❌ 0 / ⚠️ 4 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-8750-to-cloud-1.39

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@christian-byrne christian-byrne merged commit 177f833 into cloud/1.39 Feb 17, 2026
37 of 38 checks passed
@christian-byrne christian-byrne deleted the backport-8750-to-cloud-1.39 branch February 17, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants