fix: replace vite preload error reload with error logging #8261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/23/2026, 06:46:35 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Contributor
📝 WalkthroughWalkthroughReplaced the previous vite preload-error handling in Changes
Sequence Diagram(s)sequenceDiagram
participant VitePreloader as Vite Preloader
participant App as App.vue
participant Sentry as Sentry (external)
VitePreloader->>App: emit vite:preloadError(error)
App->>App: event.preventDefault()\nconsole.error(error)
alt cloud distribution
App->>Sentry: captureException(error)
else non-cloud
App-->>App: no Sentry capture (console only)
end
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.2 kB (baseline 22.7 kB) • 🟢 -483 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 949 kB (baseline 949 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 440 kB (baseline 440 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.17 MB (baseline 3.17 MB) • 🟢 -275 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 24 kB (baseline 24 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.36 MB (baseline 6.36 MB) • 🟢 -192 BBundles that do not match a named category
Status: 30 added / 30 removed |
Contributor
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
Can we log to Sentry if isCloud is true? There are some examples of this in
jtydhr88
force-pushed
the
fix/remove-vite-preload-reload
branch
from
7a481c8 to
6361329
Compare
dosubot
bot
added
size:M
jtydhr88
force-pushed
the
fix/remove-vite-preload-reload
branch
2 times, most recently
from
d739735 to
6eb0737
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/App.vue`:
- Around line 52-59: The preload error handler currently only reports to Sentry
when __DISTRIBUTION__ === 'cloud', leaving non-cloud runs silent; update the
window.addEventListener('vite:preloadError', ...) handler to log the error
payload in non-cloud environments (e.g., via console.error) while keeping the
Sentry.captureException call for cloud, referencing the existing event listener
and the __DISTRIBUTION__ check to locate the code.
6eb0737 to
8edf734
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/App.vue`:
- Around line 52-60: The vite:preloadError handler must call
event.preventDefault() to stop Vite from rethrowing the import error; inside the
window.addEventListener('vite:preloadError', (event) => { ... }) callback, call
event.preventDefault() immediately (before Sentry.captureException or
console.error) so the error is treated as handled, then proceed with the
existing cloud branch (Sentry.captureException with tags) or the console.error
branch.
DrJKL
reviewed
Jan 23, 2026
DrJKL
reviewed
Jan 23, 2026
DrJKL
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reload approach didn't fully work because CSS and other preload errors emit different error types. Log errors for Sentry tracking instead, to be solved on the backend by serving chunks from past deployments.
fix #8153
┆Issue is synchronized with this Notion page by Unito