Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR introduces comprehensive workspace member management and team workspace invitation functionality, including new dialog components for member/invite operations, invite URL query parameter handling, extended permission/UI configurations, and feature-flag-driven UI integration. Changes
Sequence Diagram(s)sequenceDiagram
participant App as GraphCanvas/App
participant Watcher as Feature Flag Watcher
participant Loader as useInviteUrlLoader
participant Store as teamWorkspaceStore
participant API as Workspace API
participant Router as Router
participant Toast as Toast Service
App->>Watcher: Setup (on mounted)
Watcher->>Watcher: Watch teamWorkspacesEnabled
Watcher->>Loader: loadInviteFromUrl() when flag true
Loader->>Loader: Check URL for 'invite' param
alt Invite param exists
Loader->>Loader: Restore preserved query
Loader->>Loader: Merge preserved into route
Loader->>Store: acceptInvite(token)
Store->>API: POST /accept-invite
API-->>Store: Success/Error response
alt Accept successful
Store-->>Loader: Success
Loader->>Toast: Show success message
else Accept failed
Store-->>Loader: Error
Loader->>Toast: Show error message
end
end
Loader->>Router: Remove 'invite' param from URL
Loader->>Loader: Clear preserved query
Loader-->>App: Complete
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/24/2026, 09:46:33 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.8 kB (baseline 22.5 kB) • 🔴 +306 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 957 kB (baseline 955 kB) • 🔴 +2.05 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed Panels & Settings — 462 kB (baseline 440 kB) • 🔴 +21.6 kBConfiguration panels, inspectors, and settings screens
Status: 24 added / 24 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • 🔴 +48 BReusable component library chunks
Status: 9 added / 9 removed Data & Services — 3.18 MB (baseline 3.17 MB) • 🔴 +9.03 kBStores, services, APIs, and repositories
Status: 9 added / 9 removed Utilities & Hooks — 25.2 kB (baseline 24 kB) • 🔴 +1.19 kBHelpers, composables, and utility bundles
Status: 10 added / 10 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 5 added / 5 removed Other — 6.43 MB (baseline 6.42 MB) • 🔴 +14.6 kBBundles that do not match a named category
Status: 88 added / 86 removed |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
- Add edit, leave, and delete workspace dialog content components - Add workspace settings panel with subscription content - Fix subscription auth to use Firebase token instead of workspace token - Disable subscribe button until billing BE is ready - Hide edit option for personal workspaces in menu Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
simula-r
added
the
preview-cpu
simula-r
force-pushed
the
workspaces-4-members-invites
branch
from
7365b88 to
83a439f
Compare
dosubot
bot
added
the
size:XXL
coderabbitai
bot
requested review from
KarryCharon,
Yorha4D,
christian-byrne and
shinshin86
simula-r
added
needs-backport
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 16
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
src/components/dialog/content/workspace/CreateWorkspaceDialogContent.vue (1)
12-18: Consider using a common button component for the close icon.Based on learnings, prefer the repo's common button components over plain HTML
<button>elements for consistency and theming. AnIconButtonfromsrc/components/button/would be appropriate here.src/platform/workspace/composables/useWorkspaceUI.ts (1)
81-94: Unused grid column values for personal workspace.For personal workspaces,
showMembersList,showPendingTab, andshowDateColumnare allfalse, yetmembersGridCols,pendingGridCols, andheaderGridColsare still defined. While this doesn't cause issues, consider using empty strings or a sentinel value to make it explicit these aren't used, or document this is for type completeness.src/components/topbar/CurrentUserPopoverWorkspace.vue (1)
76-78: Logic inconsistency between "Add Credits" button and displayed credits.The "Add Credits" button visibility check uses
isActiveSubscription && isWorkspaceSubscribed, butdisplayedCredits(lines 241-246) uses a different logic: personal workspaces checkisActiveSubscription, while team workspaces checkisWorkspaceSubscribed. This inconsistency could result in:
- A personal workspace showing "0" credits when subscribed (because
isWorkspaceSubscribedwould be false)- The "Add Credits" button being hidden for a subscribed personal workspace
Consider aligning the condition:
🐛 Suggested fix
<Button - v-if="isActiveSubscription && isWorkspaceSubscribed" + v-if="isPersonalWorkspace ? isActiveSubscription : isWorkspaceSubscribed" variant="secondary" size="sm"src/components/dialog/GlobalDialog.vue (1)
7-12: Usecn()instead of array syntax for class binding.Per coding guidelines, never use
:class="[]"for merging class names; always usecn()from@/utils/tailwindUtil.♻️ Suggested refactor
+import { cn } from '@/utils/tailwindUtil' +const dialogClass = computed(() => + cn( + 'global-dialog', + item.key === 'global-settings' && teamWorkspacesEnabled.value + ? 'settings-dialog-workspace' + : '' + ) +)Then in template:
- :class="[ - 'global-dialog', - item.key === 'global-settings' && teamWorkspacesEnabled - ? 'settings-dialog-workspace' - : '' - ]" + :class="cn( + 'global-dialog', + item.key === 'global-settings' && teamWorkspacesEnabled + ? 'settings-dialog-workspace' + : '' + )"src/platform/cloud/subscription/components/SubscriptionPanelContentWorkspace.vue (1)
446-450: Style block may be necessary for PrimeVue deep styling.While coding guidelines suggest avoiding
<style>blocks, the:deep()selector is needed to override PrimeVue component internals. Consider adding a comment explaining why this override is necessary, or explore if this can be achieved via PrimeVue's passthrough (PT) system instead.
🤖 Fix all issues with AI agents
In `@src/components/dialog/content/setting/MembersPanelContent.vue`:
- Around line 457-462: The sort logic uses sortField (cast to 'inviteDate' |
'expiryDate') and calls .getTime() blindly, which can break when switching tabs
because PendingInvite doesn’t have joinDate; update the tab-switch or sort logic
to avoid this: either reset sortField to a valid pending-invite field when
current view changes (watch the tab state and set sortField to a safe default),
or guard the comparator inside the result.sort (check that a[field] and b[field]
exist and fall back to 0 or a stable tie-breaker) so .getTime() is never called
on undefined; look for symbols sortField, sortDirection, result.sort (and the
computed/filteredPendingInvites or filteredMembers computed) to apply the fix.
- Around line 324-329: Replace the plain HTML <button> with the project's common
Button component to follow design-system conventions: import the shared Button
(e.g., from src/components/button or src/components/ui/button) into
MembersPanelContent.vue and replace the element that calls handleCreateWorkspace
(the template button bound to `@click`="handleCreateWorkspace" and text
$t('workspacePanel.members.createNewWorkspace')) with that Button component,
preserving the click handler, translation key, and existing classes/props as
appropriate (use the Button's props for variant/underline styling instead of raw
classes).
In `@src/components/dialog/content/setting/WorkspacePanelContent.vue`:
- Around line 233-237: The onMounted callback calls async functions
fetchMembers() and fetchPendingInvites() without handling rejections; update the
onMounted(() => { ... }) block (which also calls setActiveTab(defaultTab)) to
handle async errors by either awaiting those calls inside an async function with
try/catch or chaining .catch(...) on each promise and logging or otherwise
handling failures (e.g., process errors via a local logger or show a user-facing
error state). Ensure you reference and update the onMounted callback and the
invocations of fetchMembers and fetchPendingInvites so no unhandled promise
rejections occur.
In `@src/components/dialog/content/workspace/CreateWorkspaceDialogContent.vue`:
- Around line 80-84: Extract the duplicated workspace name validation into a
shared utility: create src/platform/workspace/utils/workspaceValidation.ts
exporting WORKSPACE_NAME_REGEX, WORKSPACE_NAME_MIN_LENGTH,
WORKSPACE_NAME_MAX_LENGTH and a function isValidWorkspaceName(name: string):
boolean that implements the current logic (trim, length bounds, regex.test).
Replace the inline safeNameRegex and the isValidName computed in
CreateWorkspaceDialogContent.vue and the identical logic in
EditWorkspaceDialogContent.vue to call isValidWorkspaceName(workspaceName.value)
(or use the constants if needed) so both dialogs use the single source of truth.
In `@src/components/dialog/content/workspace/InviteMemberDialogContent.vue`:
- Around line 93-94: The SVG uses a hardcoded clipPath id "clip0_2127_14348" in
InviteMemberDialogContent.vue which can collide when multiple instances render;
update the template to generate a unique id per component instance (e.g.,
compose a base name with a unique suffix like the component UID or a short
random/token from data/computed) and bind that id to both the <clipPath> and the
corresponding clip-path attribute, or remove the clipPath entirely if it's not
required; update references in the SVG (the clip-path attribute) to use the same
dynamic id so they remain consistent.
- Around line 16-22: Replace the raw close <button> in
InviteMemberDialogContent.vue with the shared IconButton component used in
RevokeInviteDialogContent.vue: remove the custom <button> and <i> markup and
render <IconButton> (or the project’s common icon button) with the same
:aria-label="$t('g.close')" and `@click`="onCancel", supply the same icon (e.g.,
"pi pi-times" or via an icon prop/slot) and any needed styling props, and ensure
IconButton is imported/registered in the component so theming and accessibility
match the other dialog.
- Around line 72-98: The copy icon block uses a non-interactive <div> with
`@click` and a hardcoded stroke color; replace the outer <div> with a <button
type="button"> (keep the existing classes like "absolute right-4 top-2
cursor-pointer" but add accessible attributes such as aria-label="Copy invite
link" and a visible focus style) and move the `@click`="onCopyLink" to that button
so the onCopyLink method is keyboard- and screen-reader-accessible; update the
SVG stroke="white" to stroke="currentColor" and ensure the button has an
appropriate text color class (or inline color) so the icon adapts to light/dark
themes; ensure no other event handlers rely on the element being a div.
- Around line 143-152: The onCreateLink function lacks error handling so if
workspaceStore.createInviteLink(email.value) throws the user sees no feedback;
update onCreateLink to add a catch block that captures the thrown error, sets
loading.value = false, and shows a toast error like the existing onCopyLink
pattern (use the same toast.error call and message composition, e.g., include
error.message), while keeping the success path that sets generatedLink.value and
step.value = 'link'.
In `@src/components/dialog/content/workspace/RemoveMemberDialogContent.vue`:
- Around line 12-18: Replace the raw <button> in RemoveMemberDialogContent.vue
with the shared IconButton component: import IconButton and render it instead of
the HTML button, pass the aria-label binding (:aria-label="$t('g.close')") and
wire the `@click`="onCancel" listener, supply the pi pi-times icon (using
IconButton's icon prop or default slot as used across the codebase), and remove
the old button-specific classes since IconButton handles styling/theming. Ensure
the component is added to the component registration/exports so the template
recognizes IconButton.
In `@src/components/dialog/content/workspace/RevokeInviteDialogContent.vue`:
- Around line 12-18: Replace the raw <button> with the shared IconButton
component in RevokeInviteDialogContent.vue: import IconButton from the button
library (src/components/button/IconButton), remove the plain button element and
use <IconButton> instead, passing the aria-label via :aria-label="$t('g.close')"
and the click handler via `@click`="onCancel", and ensure the close icon (pi
pi-times) is rendered inside IconButton or passed via its icon prop and the same
styling/size is preserved; update imports and remove the old button markup so
the component uses the centralized IconButton for consistent theming.
- Around line 59-67: The onRevoke function currently swallows errors from
workspaceStore.revokeInvite(inviteId); add an explicit catch to handle failures:
catch the thrown error, call the same toast/notification helper used in
InviteMemberDialogContent.vue to display a user-facing failure message (include
error.message when available), then keep the existing finally block to set
loading.value = false; ensure dialogStore.closeDialog({ key: 'revoke-invite' })
remains in the success path only and do not rethrow the error after showing the
toast.
In `@src/components/topbar/WorkspaceSwitcherPopover.vue`:
- Around line 125-126: Remove the locally defined SubscriptionPlan type in
WorkspaceSwitcherPopover.vue and instead import SubscriptionPlan from the
existing definition in teamWorkspaceStore
(src/platform/workspace/stores/teamWorkspaceStore.ts); update the top of
WorkspaceSwitcherPopover.vue to add the import for SubscriptionPlan and delete
the local type alias so the component uses the single shared SubscriptionPlan
type from teamWorkspaceStore.
In `@src/platform/settings/components/SettingDialogContent.vue`:
- Around line 16-25: The v-model binding on the SearchBox uses the verbose form
v-model:model-value; change it to the standard shorthand v-model (i.e. bind
searchQuery with v-model="searchQuery") in the SettingDialogContent.vue template
where SearchBox is declared so the component still updates searchQuery and
handleSearch remains attached to the `@search` event.
In `@src/platform/workspace/api/workspaceApi.ts`:
- Around line 115-125: Extract the duplicated logic in getAuthHeaderOrThrow and
getFirebaseHeaderOrThrow into a single helper getHeaderOrThrow(getter) that
accepts an async getter returning AuthHeader | null, calls it, throws the
existing WorkspaceApiError with t('toastMessages.userNotAuthenticated'), 401,
'NOT_AUTHENTICATED' when null, and returns the header otherwise; then change
getAuthHeaderOrThrow and getFirebaseHeaderOrThrow to call getHeaderOrThrow(() =>
useAuthStore().getAuthHeader()) and getHeaderOrThrow(() =>
useFirebaseAuthStore().getFirebaseAuthHeader()) respectively (referencing the
existing function names getAuthHeaderOrThrow, getFirebaseHeaderOrThrow,
getHeaderOrThrow, WorkspaceApiError, and t).
In `@src/platform/workspace/composables/useWorkspaceUI.ts`:
- Around line 38-48: Update the personal-workspace UI permissions in
useWorkspaceUI.ts to reflect backend behavior by setting canLeaveWorkspace to
false; specifically change the returned object for the 'personal' branch (where
canLeaveWorkspace is currently true) so the UI won't show a leave action that
conflicts with teamWorkspaceStore.ts::leaveWorkspace() which throws "Cannot
leave personal workspace", and also ensure any UI configuration that sets
workspaceMenuAction to 'leave' for personal workspaces is removed or changed to
a non-leave action to keep front-end and backend consistent.
In `@src/services/dialogService.ts`:
- Around line 631-647: The empty onConfirm: () => {} in
showBillingComingSoonDialog is a no-op; either remove the onConfirm prop from
the props object or set it explicitly to undefined and add a short inline
comment to indicate the no-op is intentional for an info-only dialog (locate
showBillingComingSoonDialog, dialogStore.showDialog, and
ConfirmationDialogContent to apply the change).
Comment on lines
+324
to
+329
| <button | ||
| class="underline bg-transparent border-none cursor-pointer" | ||
| @click="handleCreateWorkspace" | ||
| > | ||
| {{ $t('workspacePanel.members.createNewWorkspace') }} | ||
| </button> |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Use Button component instead of plain <button> element.
Per project conventions, prefer the common button components from src/components/button/ or src/components/ui/button/ over plain HTML <button> elements for consistent theming.
Proposed fix
- <button
- class="underline bg-transparent border-none cursor-pointer"
+ <Button
+ variant="textonly"
+ size="sm"
`@click`="handleCreateWorkspace"
>
{{ $t('workspacePanel.members.createNewWorkspace') }}
- </button>
+ </Button>Based on learnings, the repo prefers common button components over plain HTML elements for design system consistency.
🤖 Prompt for AI Agents
In `@src/components/dialog/content/setting/MembersPanelContent.vue` around lines
324 - 329, Replace the plain HTML <button> with the project's common Button
component to follow design-system conventions: import the shared Button (e.g.,
from src/components/button or src/components/ui/button) into
MembersPanelContent.vue and replace the element that calls handleCreateWorkspace
(the template button bound to `@click`="handleCreateWorkspace" and text
$t('workspacePanel.members.createNewWorkspace')) with that Button component,
preserving the click handler, translation key, and existing classes/props as
appropriate (use the Button's props for variant/underline styling instead of raw
classes).
Comment on lines
233
to
237
| onMounted(() => { | ||
| setActiveTab(defaultTab) | ||
| fetchMembers() | ||
| fetchPendingInvites() | ||
| }) |
Contributor
There was a problem hiding this comment.
Unhandled promise rejections from async data fetching.
fetchMembers() and fetchPendingInvites() are async functions that return promises, but the errors are not handled. If either API call fails, the promise rejection will be unhandled.
Consider adding error handling or using a fire-and-forget pattern that suppresses errors gracefully.
Proposed fix: Add error handling
onMounted(() => {
setActiveTab(defaultTab)
- fetchMembers()
- fetchPendingInvites()
+ fetchMembers().catch(() => {
+ // Silent fail - members list will remain empty
+ })
+ fetchPendingInvites().catch(() => {
+ // Silent fail - pending invites will remain empty
+ })
})Alternatively, if errors should be surfaced:
+import { useToast } from 'primevue/usetoast'
+const toast = useToast()
onMounted(async () => {
setActiveTab(defaultTab)
+ try {
+ await Promise.all([fetchMembers(), fetchPendingInvites()])
+ } catch {
+ toast.add({
+ severity: 'error',
+ summary: t('g.error'),
+ detail: t('workspacePanel.members.fetchError'),
+ life: 3000
+ })
+ }
- fetchMembers()
- fetchPendingInvites()
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| onMounted(() => { | |
| setActiveTab(defaultTab) | |
| fetchMembers() | |
| fetchPendingInvites() | |
| }) | |
| onMounted(() => { | |
| setActiveTab(defaultTab) | |
| fetchMembers().catch(() => { | |
| // Silent fail - members list will remain empty | |
| }) | |
| fetchPendingInvites().catch(() => { | |
| // Silent fail - pending invites will remain empty | |
| }) | |
| }) |
🤖 Prompt for AI Agents
In `@src/components/dialog/content/setting/WorkspacePanelContent.vue` around lines
233 - 237, The onMounted callback calls async functions fetchMembers() and
fetchPendingInvites() without handling rejections; update the onMounted(() => {
... }) block (which also calls setActiveTab(defaultTab)) to handle async errors
by either awaiting those calls inside an async function with try/catch or
chaining .catch(...) on each promise and logging or otherwise handling failures
(e.g., process errors via a local logger or show a user-facing error state).
Ensure you reference and update the onMounted callback and the invocations of
fetchMembers and fetchPendingInvites so no unhandled promise rejections occur.
Comment on lines
80
to
84
| const isValidName = computed(() => { | ||
| const name = workspaceName.value.trim() | ||
| // Allow alphanumeric, spaces, hyphens, underscores (safe characters) | ||
| const safeNameRegex = /^[a-zA-Z0-9][a-zA-Z0-9\s\-_]*$/ | ||
| const safeNameRegex = /^[a-zA-Z0-9][a-zA-Z0-9\s\-_'.,()&+]*$/ | ||
| return name.length >= 1 && name.length <= 50 && safeNameRegex.test(name) | ||
| }) |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider extracting shared validation logic.
The safeNameRegex and validation logic are duplicated identically in EditWorkspaceDialogContent.vue. Extract to a shared utility (e.g., workspaceValidation.ts) to ensure both dialogs stay in sync and simplify future updates.
♻️ Suggested shared utility
Create a new file src/platform/workspace/utils/workspaceValidation.ts:
export const WORKSPACE_NAME_REGEX = /^[a-zA-Z0-9][a-zA-Z0-9\s\-_'.,()&+]*$/
export const WORKSPACE_NAME_MIN_LENGTH = 1
export const WORKSPACE_NAME_MAX_LENGTH = 50
export function isValidWorkspaceName(name: string): boolean {
const trimmed = name.trim()
return (
trimmed.length >= WORKSPACE_NAME_MIN_LENGTH &&
trimmed.length <= WORKSPACE_NAME_MAX_LENGTH &&
WORKSPACE_NAME_REGEX.test(trimmed)
)
}Then in both dialog components:
+import { isValidWorkspaceName } from '@/platform/workspace/utils/workspaceValidation'
const isValidName = computed(() => {
- const name = workspaceName.value.trim()
- const safeNameRegex = /^[a-zA-Z0-9][a-zA-Z0-9\s\-_'.,()&+]*$/
- return name.length >= 1 && name.length <= 50 && safeNameRegex.test(name)
+ return isValidWorkspaceName(workspaceName.value)
})🤖 Prompt for AI Agents
In `@src/components/dialog/content/workspace/CreateWorkspaceDialogContent.vue`
around lines 80 - 84, Extract the duplicated workspace name validation into a
shared utility: create src/platform/workspace/utils/workspaceValidation.ts
exporting WORKSPACE_NAME_REGEX, WORKSPACE_NAME_MIN_LENGTH,
WORKSPACE_NAME_MAX_LENGTH and a function isValidWorkspaceName(name: string):
boolean that implements the current logic (trim, length bounds, regex.test).
Replace the inline safeNameRegex and the isValidName computed in
CreateWorkspaceDialogContent.vue and the identical logic in
EditWorkspaceDialogContent.vue to call isValidWorkspaceName(workspaceName.value)
(or use the constants if needed) so both dialogs use the single source of truth.
Comment on lines
+16
to
+22
| <button | ||
| class="cursor-pointer rounded border-none bg-transparent p-0 text-muted-foreground transition-colors hover:text-base-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-secondary-foreground" | ||
| :aria-label="$t('g.close')" | ||
| @click="onCancel" | ||
| > | ||
| <i class="pi pi-times size-4" /> | ||
| </button> |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider using IconButton for the close button.
Same as in RevokeInviteDialogContent.vue - prefer common button components for consistency and theming.
🤖 Prompt for AI Agents
In `@src/components/dialog/content/workspace/InviteMemberDialogContent.vue` around
lines 16 - 22, Replace the raw close <button> in InviteMemberDialogContent.vue
with the shared IconButton component used in RevokeInviteDialogContent.vue:
remove the custom <button> and <i> markup and render <IconButton> (or the
project’s common icon button) with the same :aria-label="$t('g.close')" and
`@click`="onCancel", supply the same icon (e.g., "pi pi-times" or via an icon
prop/slot) and any needed styling props, and ensure IconButton is
imported/registered in the component so theming and accessibility match the
other dialog.
Comment on lines
+125
to
+126
| type SubscriptionPlan = 'PRO_MONTHLY' | 'PRO_YEARLY' | null | ||
|
|
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if SubscriptionPlan type is defined elsewhere in the codebase
rg "type SubscriptionPlan" --type ts
echo "---"
# Check for subscriptionPlan in workspace directory
rg "subscriptionPlan" src/platform/workspace/ --type ts
echo "---"
# Check WorkspaceSwitcherPopover.vue for context
rg "type SubscriptionPlan" src/components/topbar/WorkspaceSwitcherPopover.vue -A 5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 773
Import SubscriptionPlan type from teamWorkspaceStore instead of defining it locally.
The SubscriptionPlan type is already defined in src/platform/workspace/stores/teamWorkspaceStore.ts with the identical definition. Remove the local type definition at lines 125-126 and import it from the store to maintain a single source of truth.
🤖 Prompt for AI Agents
In `@src/components/topbar/WorkspaceSwitcherPopover.vue` around lines 125 - 126,
Remove the locally defined SubscriptionPlan type in WorkspaceSwitcherPopover.vue
and instead import SubscriptionPlan from the existing definition in
teamWorkspaceStore (src/platform/workspace/stores/teamWorkspaceStore.ts); update
the top of WorkspaceSwitcherPopover.vue to add the import for SubscriptionPlan
and delete the local type alias so the component uses the single shared
SubscriptionPlan type from teamWorkspaceStore.
Contributor
There was a problem hiding this comment.
Coderabbit comment above seems valid.
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if SubscriptionPlan type is defined in teamWorkspaceStore
echo "=== Checking teamWorkspaceStore.ts for SubscriptionPlan type ==="
cat src/platform/workspace/stores/teamWorkspaceStore.ts | grep -n "SubscriptionPlan" -A 2 -B 2
echo -e "\n=== All SubscriptionPlan type definitions in codebase ==="
rg "type SubscriptionPlan|interface SubscriptionPlan" --type ts -n
echo -e "\n=== All usages of subscriptionPlan property ==="
rg "subscriptionPlan" --type ts -n | head -20
Length of output: 1223
🏁 Script executed:
#!/bin/bash
# Check if SubscriptionPlan is exported from teamWorkspaceStore
echo "=== Checking exports in teamWorkspaceStore.ts ==="
rg "export.*SubscriptionPlan" src/platform/workspace/stores/teamWorkspaceStore.ts -n
echo -e "\n=== Checking all export statements near SubscriptionPlan definition ==="
sed -n '30,40p' src/platform/workspace/stores/teamWorkspaceStore.ts
echo -e "\n=== Checking if WorkspaceState is exported ==="
rg "export.*WorkspaceState" src/platform/workspace/stores/teamWorkspaceStore.ts -n
Length of output: 432
@christian-byrne Actually, I need to correct myself - my original suggestion was mistaken.
After checking the codebase, the SubscriptionPlan type in teamWorkspaceStore.ts is not exported - it's defined as a private internal type used only within that store. The local definition in WorkspaceSwitcherPopover.vue is appropriate here.
Based on this project's principle of keeping the API surface minimal (only exporting when there's concrete usage elsewhere), the current approach with separate local definitions is actually the right pattern. The type is simple enough that having it defined in both places is acceptable and maintains proper encapsulation.
Sorry for the confusion in my initial review! The current code is fine as-is.
🧠 Learnings used
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7894
File: src/renderer/extensions/vueNodes/widgets/components/WidgetToggleSwitch.test.ts:11-14
Timestamp: 2026-01-08T02:40:22.621Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: When testing components, import the real type definitions from the component files instead of duplicating interface definitions in the test files. This prevents type drift and maintains consistency.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/AGENTS.md:0-0
Timestamp: 2026-01-16T21:33:47.062Z
Learning: Applies to src/**/store/**/*.{js,ts} : Clean up subscriptions to prevent memory leaks in stores
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:21.073Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, linting rules enforce keeping `import type` statements separate from regular `import` statements, even when importing from the same module. Do not suggest consolidating them into a single import statement.
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8248
File: src/platform/assets/schemas/assetSchema.ts:109-118
Timestamp: 2026-01-22T23:45:06.746Z
Learning: In the ComfyUI_frontend repository, don't suggest exporting schemas, constants, or other declarations unless they are actually used in other parts of the codebase. Keep the API surface minimal until there's a concrete need.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-22T17:18:17.636Z
Learning: Applies to src/**/*.ts : Use separate `import type` statements for types, not inline `type` in mixed imports
Comment on lines
16
to
25
| <div class="px-4"> | ||
| <SearchBox | ||
| v-model:model-value="searchQuery" | ||
| class="settings-search-box mb-2 w-full" | ||
| :placeholder="$t('g.searchSettings') + '...'" | ||
| :debounce-time="128" | ||
| autofocus | ||
| @search="handleSearch" | ||
| /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Simplify the v-model binding.
v-model:model-value is equivalent to v-model but unnecessarily verbose. Use the standard shorthand form.
♻️ Suggested simplification
<SearchBox
- v-model:model-value="searchQuery"
+ v-model="searchQuery"
class="settings-search-box mb-2 w-full"
:placeholder="$t('g.searchSettings') + '...'"
:debounce-time="128"
autofocus
`@search`="handleSearch"
/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <div class="px-4"> | |
| <SearchBox | |
| v-model:model-value="searchQuery" | |
| class="settings-search-box mb-2 w-full" | |
| :placeholder="$t('g.searchSettings') + '...'" | |
| :debounce-time="128" | |
| autofocus | |
| @search="handleSearch" | |
| /> | |
| </div> | |
| <div class="px-4"> | |
| <SearchBox | |
| v-model="searchQuery" | |
| class="settings-search-box mb-2 w-full" | |
| :placeholder="$t('g.searchSettings') + '...'" | |
| :debounce-time="128" | |
| autofocus | |
| `@search`="handleSearch" | |
| /> | |
| </div> |
🤖 Prompt for AI Agents
In `@src/platform/settings/components/SettingDialogContent.vue` around lines 16 -
25, The v-model binding on the SearchBox uses the verbose form
v-model:model-value; change it to the standard shorthand v-model (i.e. bind
searchQuery with v-model="searchQuery") in the SettingDialogContent.vue template
where SearchBox is declared so the component still updates searchQuery and
handleSearch remains attached to the `@search` event.
Comment on lines
+115
to
+125
| async function getFirebaseHeaderOrThrow() { | ||
| const authHeader = await useFirebaseAuthStore().getFirebaseAuthHeader() | ||
| if (!authHeader) { | ||
| throw new WorkspaceApiError( | ||
| t('toastMessages.userNotAuthenticated'), | ||
| 401, | ||
| 'NOT_AUTHENTICATED' | ||
| ) | ||
| } | ||
| return authHeader | ||
| } |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider extracting shared logic to reduce duplication.
getFirebaseHeaderOrThrow is nearly identical to getAuthHeaderOrThrow (lines 103-113). Consider a shared helper:
async function getHeaderOrThrow(
getter: () => Promise<AuthHeader | null>
): Promise<AuthHeader> {
const authHeader = await getter()
if (!authHeader) {
throw new WorkspaceApiError(
t('toastMessages.userNotAuthenticated'),
401,
'NOT_AUTHENTICATED'
)
}
return authHeader
}Then use it as:
const getAuthHeaderOrThrow = () =>
getHeaderOrThrow(() => useFirebaseAuthStore().getAuthHeader())
const getFirebaseHeaderOrThrow = () =>
getHeaderOrThrow(() => useFirebaseAuthStore().getFirebaseAuthHeader())This is a minor improvement; the current implementation is clear and works correctly.
🤖 Prompt for AI Agents
In `@src/platform/workspace/api/workspaceApi.ts` around lines 115 - 125, Extract
the duplicated logic in getAuthHeaderOrThrow and getFirebaseHeaderOrThrow into a
single helper getHeaderOrThrow(getter) that accepts an async getter returning
AuthHeader | null, calls it, throws the existing WorkspaceApiError with
t('toastMessages.userNotAuthenticated'), 401, 'NOT_AUTHENTICATED' when null, and
returns the header otherwise; then change getAuthHeaderOrThrow and
getFirebaseHeaderOrThrow to call getHeaderOrThrow(() =>
useAuthStore().getAuthHeader()) and getHeaderOrThrow(() =>
useFirebaseAuthStore().getFirebaseAuthHeader()) respectively (referencing the
existing function names getAuthHeaderOrThrow, getFirebaseHeaderOrThrow,
getHeaderOrThrow, WorkspaceApiError, and t).
Comment on lines
+631
to
+647
| function showBillingComingSoonDialog() { | ||
| return dialogStore.showDialog({ | ||
| key: 'billing-coming-soon', | ||
| title: t('subscription.billingComingSoon.title'), | ||
| component: ConfirmationDialogContent, | ||
| props: { | ||
| message: t('subscription.billingComingSoon.message'), | ||
| type: 'info' as ConfirmationDialogType, | ||
| onConfirm: () => {} | ||
| }, | ||
| dialogComponentProps: { | ||
| pt: { | ||
| root: { class: 'max-w-[360px]' } | ||
| } | ||
| } | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Empty onConfirm callback for info dialog is intentional but could be cleaner.
The onConfirm: () => {} is a no-op since info dialogs only show an OK button that closes the dialog. Consider adding a brief comment or using a more explicit approach.
Optional: Add clarity for no-op callback
function showBillingComingSoonDialog() {
return dialogStore.showDialog({
key: 'billing-coming-soon',
title: t('subscription.billingComingSoon.title'),
component: ConfirmationDialogContent,
props: {
message: t('subscription.billingComingSoon.message'),
type: 'info' as ConfirmationDialogType,
- onConfirm: () => {}
+ // Info dialogs only show OK button; onConfirm unused but required by props
+ onConfirm: () => {}
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function showBillingComingSoonDialog() { | |
| return dialogStore.showDialog({ | |
| key: 'billing-coming-soon', | |
| title: t('subscription.billingComingSoon.title'), | |
| component: ConfirmationDialogContent, | |
| props: { | |
| message: t('subscription.billingComingSoon.message'), | |
| type: 'info' as ConfirmationDialogType, | |
| onConfirm: () => {} | |
| }, | |
| dialogComponentProps: { | |
| pt: { | |
| root: { class: 'max-w-[360px]' } | |
| } | |
| } | |
| }) | |
| } | |
| function showBillingComingSoonDialog() { | |
| return dialogStore.showDialog({ | |
| key: 'billing-coming-soon', | |
| title: t('subscription.billingComingSoon.title'), | |
| component: ConfirmationDialogContent, | |
| props: { | |
| message: t('subscription.billingComingSoon.message'), | |
| type: 'info' as ConfirmationDialogType, | |
| // Info dialogs only show OK button; onConfirm unused but required by props | |
| onConfirm: () => {} | |
| }, | |
| dialogComponentProps: { | |
| pt: { | |
| root: { class: 'max-w-[360px]' } | |
| } | |
| } | |
| }) | |
| } |
🤖 Prompt for AI Agents
In `@src/services/dialogService.ts` around lines 631 - 647, The empty onConfirm:
() => {} in showBillingComingSoonDialog is a no-op; either remove the onConfirm
prop from the props object or set it explicitly to undefined and add a short
inline comment to indicate the no-op is intentional for an info-only dialog
(locate showBillingComingSoonDialog, dialogStore.showDialog, and
ConfirmationDialogContent to apply the change).
265a5b5 to
9eb015b
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
src/platform/cloud/subscription/utils/subscriptionCheckoutUtil.ts (2)
13-16: Prefer function declaration over function expression.Per coding guidelines, prefer function declarations for pure functions.
♻️ Suggested refactor
-const getCheckoutTier = ( - tierKey: TierKey, - billingCycle: BillingCycle -): CheckoutTier => (billingCycle === 'yearly' ? `${tierKey}-yearly` : tierKey) +function getCheckoutTier( + tierKey: TierKey, + billingCycle: BillingCycle +): CheckoutTier { + return billingCycle === 'yearly' ? `${tierKey}-yearly` : tierKey +}Based on learnings, function declarations are preferred over function expressions for pure functions in this repository.
55-69: Potential issue with response body consumption.The
Responsebody is aReadableStreamthat can only be consumed once. Ifresponse.json()fails after partially reading the stream, the subsequentresponse.text()call may throw or return incomplete data.A safer approach is to read the body once as text, then attempt to parse it as JSON:
🔧 Suggested fix
if (!response.ok) { let errorMessage = 'Failed to initiate checkout' try { - const errorData = await response.json() - errorMessage = errorData.message || errorMessage + const errorText = await response.text() + if (errorText) { + try { + const errorData = JSON.parse(errorText) + errorMessage = errorData.message || errorMessage + } catch { + errorMessage = errorText + } + } else { + errorMessage = `HTTP ${response.status} ${response.statusText}` + } } catch { - // If JSON parsing fails, try to get text response or use HTTP status - try { - const errorText = await response.text() - errorMessage = - errorText || `HTTP ${response.status} ${response.statusText}` - } catch { - errorMessage = `HTTP ${response.status} ${response.statusText}` - } + errorMessage = `HTTP ${response.status} ${response.statusText}` }src/components/dialog/content/workspace/CreateWorkspaceDialogContent.vue (1)
12-18: Consider using IconButton for the close button.Based on learnings, prefer the repo's common button components over plain HTML
<button>elements. The close button could useIconButtonfrom@/components/button/IconButton.vuefor consistency with the project's design system.♻️ Suggested refactor
+import IconButton from '@/components/button/IconButton.vue'- <button - class="cursor-pointer rounded border-none bg-transparent p-0 text-muted-foreground transition-colors hover:text-base-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-secondary-foreground" - :aria-label="$t('g.close')" - `@click`="onCancel" - > - <i class="pi pi-times size-4" /> - </button> + <IconButton + icon="pi pi-times" + :aria-label="$t('g.close')" + `@click`="onCancel" + />src/components/dialog/content/workspace/EditWorkspaceDialogContent.vue (1)
12-18: Consider using IconButton for consistency.Similar to
CreateWorkspaceDialogContent.vue, the close button could use the commonIconButtoncomponent for design system consistency.src/components/topbar/CurrentUserPopoverWorkspace.vue (1)
76-102: Potential logic issue in Add Credits button visibility.Line 77 requires both
isActiveSubscription && isWorkspaceSubscribedto be true, butisActiveSubscriptioncomes from personal subscription state whileisWorkspaceSubscribedis workspace-level. For personal workspaces,isWorkspaceSubscribedmay not be set correctly, and for team workspaces,isActiveSubscriptionmay be false. This could prevent the "Add Credits" button from showing in either context.Consider aligning the condition with the
displayedCreditslogic (lines 241-245) that correctly uses an OR-like pattern based on workspace type.🔧 Suggested fix
<!-- Subscribed: Show Add Credits button --> <Button - v-if="isActiveSubscription && isWorkspaceSubscribed" + v-if="isPersonalWorkspace ? isActiveSubscription : isWorkspaceSubscribed" variant="secondary" size="sm" class="text-base-foreground" data-testid="add-credits-button" `@click`="handleTopUp" >
🤖 Fix all issues with AI agents
In `@src/components/dialog/content/setting/MembersPanelContent.vue`:
- Around line 133-138: The UserAvatar pass-through class uses a Tailwind
important modifier ('text-xl!') which violates the no-'!' rule; update the
:pt:icon:class binding on the UserAvatar component to use the regular 'text-xl'
class instead of 'text-xl!' (i.e., change the object key "{ 'text-xl!':
!userPhotoUrl }" to "{ 'text-xl': !userPhotoUrl }"), keeping the conditional on
userPhotoUrl unchanged.
In `@src/components/dialog/content/setting/WorkspacePanelContent.vue`:
- Around line 49-63: The Invite Button component currently sets an aria-label
which overrides the visible text; remove the
:aria-label="$t('workspacePanel.inviteMember')" attribute from the Button in
WorkspacePanelContent.vue (the Button rendered when permissions.canInviteMembers
is true) so the visible label "{{ $t('workspacePanel.invite') }}" becomes the
accessible name; keep the rest of the props and event handler
(isInviteLimitReached, inviteTooltip, `@click`="handleInviteMember") unchanged.
- Around line 85-89: The template in WorkspacePanelContent.vue currently uses a
:class array to merge classes; replace that array with a call to the project's
cn() utility so class merging follows the codebase convention — build the class
string by calling cn('flex items-center gap-2 px-3 py-2', item.class,
item.disabled ? 'pointer-events-auto' : 'cursor-pointer') ensuring you reference
the same item.class and item.disabled properties and import/resolve cn() in the
component if not already available.
In `@src/components/dialog/content/workspace/InviteMemberDialogContent.vue`:
- Around line 149-153: The toast in the catch block for the create-link flow
uses the wrong summary key; update the summary from
workspacePanel.inviteMemberDialog.linkCopyFailed to
workspacePanel.inviteMemberDialog.createLinkFailed in the onCreateLink error
handler (the catch inside InviteMemberDialogContent.vue where toast.add is
called) and add the corresponding message key
workspacePanel.inviteMemberDialog.createLinkFailed to src/locales/en/main.json
with an appropriate user-facing string so the toast shows an accurate
create-link failure message.
In `@src/components/dialog/content/workspace/RevokeInviteDialogContent.vue`:
- Around line 68-73: The toast in the catch block of
RevokeInviteDialogContent.vue currently leaves detail empty when the caught
value isn't an Error; update the catch block where toast.add(...) is called (the
catch surrounding the revoke invite flow) to provide a user-friendly fallback
detail (e.g. use the i18n translator t(...) for a generic "unknown error"
message) instead of undefined so the toast always shows actionable text; keep
existing severity/summary/life values and only change the detail expression to
use the error message when available or the translated fallback otherwise.
In `@src/platform/workspace/composables/useInviteUrlLoader.test.ts`:
- Around line 27-39: Replace the unsafe Record<string,string> mock type with
vue-router's LocationQuery: import { LocationQuery } from 'vue-router' and
change mockRouteQuery's value type to LocationQuery (i.e., const mockRouteQuery
= vi.hoisted(() => ({ value: {} as LocationQuery }))). Update the mock export
for useRoute to return mockRouteQuery.value as before and remove any runtime
casts like `as unknown as string` in tests that were compensating for the wrong
type; adjust assertions to use the proper LocationQuery types where needed
(references: mockRouteQuery, useRoute, mockRouterReplace).
In `@src/platform/workspace/composables/useInviteUrlLoader.ts`:
- Around line 84-88: In useInviteUrlLoader (the t(...) call for
'workspace.addedToWorkspace') remove the explicit escapeParameter: false option
so the i18n call becomes t('workspace.addedToWorkspace', { workspaceName:
result.workspaceName }) and let the default escaping remain; this ensures
workspaceName is not unescaped and follows the project's
sanitization/trusted-source guidelines.
♻️ Duplicate comments (12)
src/components/dialog/content/workspace/CreateWorkspaceDialogContent.vue (1)
80-84: Duplicate validation logic with EditWorkspaceDialogContent.vue.The
safeNameRegexand validation logic are identical in both dialog components. As noted in a previous review, consider extracting to a shared utility to ensure both dialogs stay in sync.src/components/dialog/content/workspace/EditWorkspaceDialogContent.vue (1)
70-74: Validation logic is duplicated.This validation regex and logic are identical to
CreateWorkspaceDialogContent.vue. Consider extracting to a shared utility as suggested in previous reviews.src/platform/settings/components/SettingDialogContent.vue (1)
16-25: Simplifyv-model:model-valuetov-model.The verbose
v-model:model-valuebinding is equivalent to justv-model. Use the standard shorthand.♻️ Suggested fix
<SearchBox - v-model:model-value="searchQuery" + v-model="searchQuery" class="settings-search-box mb-2 w-full" :placeholder="$t('g.searchSettings') + '...'" :debounce-time="128" autofocus `@search`="handleSearch" />src/platform/workspace/api/workspaceApi.ts (1)
114-124: Consider extracting shared logic to reduce duplication.
getFirebaseHeaderOrThrowis nearly identical togetAuthHeaderOrThrow(lines 102-112). A shared helper accepting a getter function would reduce duplication.This was already flagged in a previous review - the current implementation works correctly but could be consolidated.
src/components/dialog/content/workspace/RemoveMemberDialogContent.vue (1)
12-18: Replace plain HTML button with IconButton component.Per repository conventions, prefer the common button components from
src/components/button/over plain HTML<button>elements for consistency and theming. This was flagged in a previous review.src/components/dialog/content/workspace/RevokeInviteDialogContent.vue (1)
12-18: Replace the raw close button with the shared IconButton.The current
<button>bypasses the design-system button components and styling conventions used elsewhere.♻️ Proposed refactor
+import IconButton from '@/components/button/IconButton.vue' ... - <button - class="cursor-pointer rounded border-none bg-transparent p-0 text-muted-foreground transition-colors hover:text-base-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-secondary-foreground" - :aria-label="$t('g.close')" - `@click`="onCancel" - > - <i class="pi pi-times size-4" /> - </button> + <IconButton + icon="pi pi-times" + :aria-label="$t('g.close')" + `@click`="onCancel" + />Based on learnings, prefer the shared button components from
src/components/button/for consistency.src/components/dialog/content/workspace/InviteMemberDialogContent.vue (2)
16-22: Replace the raw close button with the shared IconButton.The dialog header still uses a custom
<button>instead of the standardized button components.♻️ Proposed refactor
+import IconButton from '@/components/button/IconButton.vue' ... - <button - class="cursor-pointer rounded border-none bg-transparent p-0 text-muted-foreground transition-colors hover:text-base-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-secondary-foreground" - :aria-label="$t('g.close')" - `@click`="onCancel" - > - <i class="pi pi-times size-4" /> - </button> + <IconButton + icon="pi pi-times" + :aria-label="$t('g.close')" + `@click`="onCancel" + />Based on learnings, prefer the shared button components from
src/components/button/.
72-97: Make the copy icon a proper button and avoid static SVG clipPath IDs.The clickable
<div>is not keyboard-accessible, the SVG color is hardcoded, and the staticclipPathID can collide across instances.♻️ Suggested fix
- <div - class="absolute right-4 top-2 cursor-pointer" - `@click`="onCopyLink" - > + <button + type="button" + class="absolute right-4 top-2 cursor-pointer border-none bg-transparent p-0 text-muted-foreground" + :aria-label="$t('workspacePanel.inviteMemberDialog.linkStep.copyLink')" + `@click`="onCopyLink" + > <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16" fill="none" > - <g clip-path="url(`#clip0_2127_14348`)"> + <g> <path d="M2.66634 10.6666C1.93301 10.6666 1.33301 10.0666 1.33301 9.33325V2.66659C1.33301 1.93325 1.93301 1.33325 2.66634 1.33325H9.33301C10.0663 1.33325 10.6663 1.93325 10.6663 2.66659M6.66634 5.33325H13.333C14.0694 5.33325 14.6663 5.93021 14.6663 6.66658V13.3333C14.6663 14.0696 14.0694 14.6666 13.333 14.6666H6.66634C5.92996 14.6666 5.33301 14.0696 5.33301 13.3333V6.66658C5.33301 5.93021 5.92996 5.33325 6.66634 5.33325Z" - stroke="white" + stroke="currentColor" stroke-width="1.3" stroke-linecap="round" stroke-linejoin="round" /> </g> - <defs> - <clipPath id="clip0_2127_14348"> - <rect width="16" height="16" fill="white" /> - </clipPath> - </defs> </svg> - </div> + </button>src/components/dialog/content/setting/MembersPanelContent.vue (1)
324-329: Use the shared Button component for the create-workspace link.The plain
<button>here bypasses the shared Button styling and theming.♻️ Proposed refactor
- <button - class="underline bg-transparent border-none cursor-pointer" - `@click`="handleCreateWorkspace" - > - {{ $t('workspacePanel.members.createNewWorkspace') }} - </button> + <Button variant="textonly" size="sm" `@click`="handleCreateWorkspace"> + {{ $t('workspacePanel.members.createNewWorkspace') }} + </Button>Based on learnings, prefer the shared Button component for consistency.
src/components/topbar/WorkspaceSwitcherPopover.vue (1)
125-126: ImportSubscriptionPlanfrom the store instead of redefining it.The type already exists in
teamWorkspaceStore; keeping a duplicate risks drift.♻️ Proposed refactor
+import type { SubscriptionPlan } from '@/platform/workspace/stores/teamWorkspaceStore' ... -type SubscriptionPlan = 'PRO_MONTHLY' | 'PRO_YEARLY' | nullsrc/components/dialog/content/setting/WorkspacePanelContent.vue (1)
233-236: Unhandled async calls in onMounted.
This is a duplicate of a prior review comment:fetchMembers()and
fetchPendingInvites()should handle rejections to avoid unhandled promises.src/services/dialogService.ts (1)
631-640: No-op onConfirm in billing dialog.
Duplicate of a prior review comment: consider removing or clarifying the no-op
callback for the info dialog.
Comment on lines
+49
to
+63
| <Button | ||
| v-if="permissions.canInviteMembers" | ||
| v-tooltip=" | ||
| inviteTooltip | ||
| ? { value: inviteTooltip, showDelay: 0 } | ||
| : { value: $t('workspacePanel.inviteMember'), showDelay: 300 } | ||
| " | ||
| variant="secondary" | ||
| size="lg" | ||
| :disabled="isInviteLimitReached" | ||
| :class="isInviteLimitReached && 'opacity-50 cursor-not-allowed'" | ||
| :aria-label="$t('workspacePanel.inviteMember')" | ||
| @click="handleInviteMember" | ||
| > | ||
| {{ $t('workspacePanel.invite') }} |
Contributor
There was a problem hiding this comment.
Remove aria-label from the text-labeled Invite button.
The visible label already provides the accessible name; an aria-label can be
redundant or override it.
♻️ Proposed fix
- :aria-label="$t('workspacePanel.inviteMember')"Based on learnings, avoid aria-label on buttons with visible text.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <Button | |
| v-if="permissions.canInviteMembers" | |
| v-tooltip=" | |
| inviteTooltip | |
| ? { value: inviteTooltip, showDelay: 0 } | |
| : { value: $t('workspacePanel.inviteMember'), showDelay: 300 } | |
| " | |
| variant="secondary" | |
| size="lg" | |
| :disabled="isInviteLimitReached" | |
| :class="isInviteLimitReached && 'opacity-50 cursor-not-allowed'" | |
| :aria-label="$t('workspacePanel.inviteMember')" | |
| @click="handleInviteMember" | |
| > | |
| {{ $t('workspacePanel.invite') }} | |
| <Button | |
| v-if="permissions.canInviteMembers" | |
| v-tooltip=" | |
| inviteTooltip | |
| ? { value: inviteTooltip, showDelay: 0 } | |
| : { value: $t('workspacePanel.inviteMember'), showDelay: 300 } | |
| " | |
| variant="secondary" | |
| size="lg" | |
| :disabled="isInviteLimitReached" | |
| :class="isInviteLimitReached && 'opacity-50 cursor-not-allowed'" | |
| `@click`="handleInviteMember" | |
| > | |
| {{ $t('workspacePanel.invite') }} |
🤖 Prompt for AI Agents
In `@src/components/dialog/content/setting/WorkspacePanelContent.vue` around lines
49 - 63, The Invite Button component currently sets an aria-label which
overrides the visible text; remove the
:aria-label="$t('workspacePanel.inviteMember')" attribute from the Button in
WorkspacePanelContent.vue (the Button rendered when permissions.canInviteMembers
is true) so the visible label "{{ $t('workspacePanel.invite') }}" becomes the
accessible name; keep the rest of the props and event handler
(isInviteLimitReached, inviteTooltip, `@click`="handleInviteMember") unchanged.
Comment on lines
+149
to
+153
| } catch (error) { | ||
| toast.add({ | ||
| severity: 'error', | ||
| summary: t('workspacePanel.inviteMemberDialog.linkCopyFailed'), | ||
| detail: error instanceof Error ? error.message : undefined, |
Contributor
There was a problem hiding this comment.
Use a create-link failure message for onCreateLink.
The toast summary uses linkCopyFailed, which is inaccurate for create-link errors.
🐛 Proposed fix
- summary: t('workspacePanel.inviteMemberDialog.linkCopyFailed'),
+ summary: t('workspacePanel.inviteMemberDialog.createLinkFailed'),Please add workspacePanel.inviteMemberDialog.createLinkFailed to src/locales/en/main.json. As per coding guidelines, error messages should be accurate and actionable.
🤖 Prompt for AI Agents
In `@src/components/dialog/content/workspace/InviteMemberDialogContent.vue` around
lines 149 - 153, The toast in the catch block for the create-link flow uses the
wrong summary key; update the summary from
workspacePanel.inviteMemberDialog.linkCopyFailed to
workspacePanel.inviteMemberDialog.createLinkFailed in the onCreateLink error
handler (the catch inside InviteMemberDialogContent.vue where toast.add is
called) and add the corresponding message key
workspacePanel.inviteMemberDialog.createLinkFailed to src/locales/en/main.json
with an appropriate user-facing string so the toast shows an accurate
create-link failure message.
Comment on lines
+68
to
+73
| } catch (error) { | ||
| toast.add({ | ||
| severity: 'error', | ||
| summary: t('g.error'), | ||
| detail: error instanceof Error ? error.message : undefined, | ||
| life: 3000 |
Contributor
There was a problem hiding this comment.
Provide a fallback detail for unknown revoke errors.
When error isn’t an Error, the toast detail is empty and the message becomes non-actionable.
🐛 Proposed fix
- detail: error instanceof Error ? error.message : undefined,
+ detail: error instanceof Error ? error.message : t('g.unknownError'),As per coding guidelines, error messages should remain user-friendly and actionable.
🤖 Prompt for AI Agents
In `@src/components/dialog/content/workspace/RevokeInviteDialogContent.vue` around
lines 68 - 73, The toast in the catch block of RevokeInviteDialogContent.vue
currently leaves detail empty when the caught value isn't an Error; update the
catch block where toast.add(...) is called (the catch surrounding the revoke
invite flow) to provide a user-friendly fallback detail (e.g. use the i18n
translator t(...) for a generic "unknown error" message) instead of undefined so
the toast always shows actionable text; keep existing severity/summary/life
values and only change the detail expression to use the error message when
available or the translated fallback otherwise.
Comment on lines
+27
to
+39
| const mockRouteQuery = vi.hoisted(() => ({ | ||
| value: {} as Record<string, string> | ||
| })) | ||
| const mockRouterReplace = vi.hoisted(() => vi.fn()) | ||
|
|
||
| vi.mock('vue-router', () => ({ | ||
| useRoute: () => ({ | ||
| query: mockRouteQuery.value | ||
| }), | ||
| useRouter: () => ({ | ||
| replace: mockRouterReplace | ||
| }) | ||
| })) |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, check the file structure and current implementation
cat -n src/platform/workspace/composables/useInviteUrlLoader.test.ts | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3543
🏁 Script executed:
# Check lines around 223-230 to see the other location needing fixing
sed -n '220,235p' src/platform/workspace/composables/useInviteUrlLoader.test.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 428
🏁 Script executed:
# Search for LocationQuery usage in test files
rg -n "LocationQuery" src -g "*.test.ts"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 576
🏁 Script executed:
# Check how vue-router is imported and used in test files
rg -n "from 'vue-router'" src -g "*.test.ts" -A 1 | head -30Repository: Comfy-Org/ComfyUI_frontend
Length of output: 244
🏁 Script executed:
# Search for other useRoute mocks in test files to see patterns
rg -n "useRoute.*mock" src -g "*.test.ts" -B 2 -A 5 | head -50Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Check vue-router version and query type definition
cat package.json | rg -A 5 -B 5 '"vue-router"'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 380
🏁 Script executed:
# Find LocationQuery type definition in node_modules or check imports
rg -n "type LocationQuery" src --max-count 5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Get more context from the working example in previousFullPath.test.ts
cat -n src/platform/cloud/onboarding/utils/previousFullPath.test.ts | head -40Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1484
🏁 Script executed:
# Check if LocationQuery allows both string and array values in the type
python3 << 'EOF'
# LocationQuery in vue-router is defined as:
# type LocationQuery = Record<string, string | string[]>
# This allows values to be either string or string[] (arrays)
# So the test file's assignment of { invite: ['array', 'value'] }
# would be valid WITHOUT the "as unknown as string" cast if typed as LocationQuery
print("LocationQuery type structure:")
print("type LocationQuery = Record<string, string | string[]>")
print("")
print("This means:")
print("- Current: Record<string, string> - only allows string values")
print("- Proposed: LocationQuery - allows string | string[] values")
print("")
print("The array ['array', 'value'] is valid for LocationQuery but not Record<string, string>")
print("So the double-cast (as unknown as string) is a workaround for the type mismatch")
EOFRepository: Comfy-Org/ComfyUI_frontend
Length of output: 156
🏁 Script executed:
# Verify the actual vue-router LocationQuery export
rg -n "export.*LocationQuery" --type ts | head -5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
Use LocationQuery type from vue-router instead of Record<string, string> to eliminate unsafe casts.
The mock currently uses Record<string, string> which doesn't match vue-router's actual query type (Record<string, string | string[]>), forcing the workaround as unknown as string cast when testing non-string query values. Import LocationQuery from vue-router and use it for the mock type—this removes the cast and aligns the test with how the API actually works, as already done in previousFullPath.test.ts.
♻️ Proposed refactor
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import type { LocationQuery } from 'vue-router'
import { useInviteUrlLoader } from './useInviteUrlLoader' const mockRouteQuery = vi.hoisted(() => ({
- value: {} as Record<string, string>
+ value: {} as LocationQuery
})) it('ignores non-string invite param', async () => {
- mockRouteQuery.value = { invite: ['array', 'value'] as unknown as string }
+ mockRouteQuery.value = { invite: ['array', 'value'] }🤖 Prompt for AI Agents
In `@src/platform/workspace/composables/useInviteUrlLoader.test.ts` around lines
27 - 39, Replace the unsafe Record<string,string> mock type with vue-router's
LocationQuery: import { LocationQuery } from 'vue-router' and change
mockRouteQuery's value type to LocationQuery (i.e., const mockRouteQuery =
vi.hoisted(() => ({ value: {} as LocationQuery }))). Update the mock export for
useRoute to return mockRouteQuery.value as before and remove any runtime casts
like `as unknown as string` in tests that were compensating for the wrong type;
adjust assertions to use the proper LocationQuery types where needed
(references: mockRouteQuery, useRoute, mockRouterReplace).
Comment on lines
+84
to
+88
| detail: t( | ||
| 'workspace.addedToWorkspace', | ||
| { workspaceName: result.workspaceName }, | ||
| { escapeParameter: false } | ||
| ), |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n src/platform/workspace/composables/useInviteUrlLoader.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 3937
🏁 Script executed:
# Check the i18n translation file
cat -n src/locales/en/main.json | grep -A 5 "addedToWorkspace"
# Check teamWorkspaceStore to see acceptInvite
git ls-files | grep -i "teamWorkspaceStore"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 446
🏁 Script executed:
cat -n src/platform/workspace/stores/teamWorkspaceStore.ts | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3506
🏁 Script executed:
# Find acceptInvite method in teamWorkspaceStore.ts
grep -n "acceptInvite" src/platform/workspace/stores/teamWorkspaceStore.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 190
🏁 Script executed:
sed -n '550,560p' src/platform/workspace/stores/teamWorkspaceStore.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 437
🏁 Script executed:
# Check the workspace API to see the response structure
grep -n "acceptInvite" src/platform/workspace/api/workspaceApi.ts
# Search for PrimeVue Toast usage in the codebase to understand detail rendering
rg "toast.add" -A 5 -B 2 | head -50Repository: Comfy-Org/ComfyUI_frontend
Length of output: 4328
🏁 Script executed:
# Check the AcceptInviteResponse type definition
sed -n '314,330p' src/platform/workspace/api/workspaceApi.ts
# Search for how PrimeVue Toast component is used in templates
rg "Toast" src/App.vue -A 3 -B 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 548
🏁 Script executed:
# Find the AcceptInviteResponse type
grep -n "AcceptInviteResponse" src/platform/workspace/api/workspaceApi.ts
# Check where Toast component is mounted in the app
fd "App.vue" --type fRepository: Comfy-Org/ComfyUI_frontend
Length of output: 298
🏁 Script executed:
# Check the AcceptInviteResponse type definition
sed -n '60,70p' src/platform/workspace/api/workspaceApi.ts
# Check the Toast component usage in App.vue
cat -n src/App.vue | grep -A 5 -B 5 "Toast"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 273
🏁 Script executed:
# Check the Toast component in App.vue
cat -n src/App.vue | head -40
# Search for Toast in the entire src directory
rg "Toast" src/App.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1811
🏁 Script executed:
# Search for Toast component in the layouts or main entry
fd "*.vue" -x grep -l "Toast" {} \;
# Check how PrimeVue is configured
fd "main.ts" -o "main.js"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 488
🏁 Script executed:
# Search for Toast component in Vue files
rg "Toast" src --type vue
# Check the main.ts file
fd main.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 154
🏁 Script executed:
# Check main.ts for Toast configuration
cat -n src/main.ts | head -60
# Search for Toast in TypeScript files
rg "Toast" src --type ts | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3969
🏁 Script executed:
# Search for Toast component usage in Vue files (all files)
rg "Toast" src --glob "*.vue" -A 3 -B 3
# Check PrimeVue configuration
cat -n src/main.ts | sed -n '60,100p'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 50382
🏁 Script executed:
# Check GlobalToast.vue more carefully to understand how detail is rendered
cat -n src/components/toast/GlobalToast.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2730
🏁 Script executed:
# Let me check PrimeVue Toast documentation or look for how detail is used
# Search for any v-html usage with toast detail
rg "detail.*v-html|v-html.*detail" src
# Check if there's any sanitization already applied to the translation output
rg "DOMPurify" src/platform/workspace --type tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 52
Reconsider disabling i18n escaping for workspaceName.
While PrimeVue Toast's detail property renders as plain text by default (not HTML), disabling escaping with escapeParameter: false is unnecessary and contradicts the coding guideline to "Sanitize HTML with DOMPurify" and "Validate trusted sources." Remove the escapeParameter option to keep default escaping:
Suggested fix
- detail: t(
- 'workspace.addedToWorkspace',
- { workspaceName: result.workspaceName },
- { escapeParameter: false }
- ),
+ detail: t('workspace.addedToWorkspace', {
+ workspaceName: result.workspaceName
+ }),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| detail: t( | |
| 'workspace.addedToWorkspace', | |
| { workspaceName: result.workspaceName }, | |
| { escapeParameter: false } | |
| ), | |
| detail: t('workspace.addedToWorkspace', { | |
| workspaceName: result.workspaceName | |
| }), |
🤖 Prompt for AI Agents
In `@src/platform/workspace/composables/useInviteUrlLoader.ts` around lines 84 -
88, In useInviteUrlLoader (the t(...) call for 'workspace.addedToWorkspace')
remove the explicit escapeParameter: false option so the i18n call becomes
t('workspace.addedToWorkspace', { workspaceName: result.workspaceName }) and let
the default escaping remain; this ensures workspaceName is not unescaped and
follows the project's sanitization/trusted-source guidelines.
christian-byrne
approved these changes
Jan 24, 2026
|
|
||
| const dialogStore = useDialogStore() | ||
|
|
||
| function getDialogPt(item: { |
| memberMenu.value?.toggle(event) | ||
| } | ||
|
|
||
| function isCurrentUser(member: WorkspaceMember): boolean { |
Contributor
There was a problem hiding this comment.
If we don't have any stable reference FK for users in the member list, I would want to create some abstraction on the currentUser concept that is like key. For now we would just duplicate the email value but if we later switch to a real key then refactoring will be a lot easier. WDYT?
Contributor
There was a problem hiding this comment.
nit (not blocking): are any pieces of the UI here potentially going to be used elsewhere? Might be worth extracting them if so. Potential way to decompose it:
MembersPanelContent.vue
├── MembersPanelHeader.vue (search + count display)
├── MembersTabBar.vue (active/pending tabs + sort buttons)
├── MembersList.vue (active members rendering)
│ └── MemberListItem.vue
├── PendingInvitesList.vue (pending invites rendering)
│ └── PendingInviteItem.vue
└── composables/
└── useMemberFiltering.ts (search, sort, filter logic)
Comment on lines
+175
to
+205
| <UserAvatar | ||
| class="size-8" | ||
| :photo-url=" | ||
| isCurrentUser(member) ? userPhotoUrl : undefined | ||
| " | ||
| :pt:icon:class="{ | ||
| 'text-xl!': !isCurrentUser(member) || !userPhotoUrl | ||
| }" | ||
| /> | ||
| <div class="flex min-w-0 flex-1 flex-col gap-1"> | ||
| <div class="flex items-center gap-2"> | ||
| <span class="text-sm text-base-foreground"> | ||
| {{ member.name }} | ||
| <span | ||
| v-if="isCurrentUser(member)" | ||
| class="text-muted-foreground" | ||
| > | ||
| ({{ $t('g.you') }}) | ||
| </span> | ||
| </span> | ||
| <span | ||
| v-if="uiConfig.showRoleBadge" | ||
| class="text-[10px] font-bold uppercase text-base-background bg-base-foreground px-1 py-0.5 rounded-full" | ||
| > | ||
| {{ getRoleBadgeLabel(member.role) }} | ||
| </span> | ||
| </div> | ||
| <span class="text-sm text-muted-foreground"> | ||
| {{ member.email }} | ||
| </span> | ||
| </div> |
Contributor
There was a problem hiding this comment.
nit/question: Since this piece is very similar to the other above, would it be worth creating something like MemberListItem.vue?
Comment on lines
+195
to
+200
| <span | ||
| v-if="uiConfig.showRoleBadge" | ||
| class="text-[10px] font-bold uppercase text-base-background bg-base-foreground px-1 py-0.5 rounded-full" | ||
| > | ||
| {{ getRoleBadgeLabel(member.role) }} | ||
| </span> |
Contributor
There was a problem hiding this comment.
nit: Do you want to create a RoleBadge.vue or add a variant to the existing Badge component? It looks like it's in this component twice and WorkspaceSwitcherPopover.vue as well
Comment on lines
+235
to
+236
| fetchMembers() | ||
| fetchPendingInvites() |
Contributor
There was a problem hiding this comment.
Does this need a loading state or is it handled in some way already? E.g., useAsyncState (or just manual) and showing our spinner until resolve.
Contributor
There was a problem hiding this comment.
nit: We have some existing patterns for things like forms / validation / email validation in the codebase that might be worth standardizing on for this component.
Comment on lines
+125
to
+126
| type SubscriptionPlan = 'PRO_MONTHLY' | 'PRO_YEARLY' | null | ||
|
|
Contributor
There was a problem hiding this comment.
Coderabbit comment above seems valid.
| const workflowPersistence = useWorkflowPersistence() | ||
| const { flags } = useFeatureFlags() | ||
| // Set up invite loader during setup phase so useRoute/useRouter work correctly | ||
| const inviteUrlLoader = isCloud ? useInviteUrlLoader() : null |
Contributor
There was a problem hiding this comment.
Might be better if the composable returned a no-op if the feature flag is off (to encapsulate complex/nuanced logic), rather than requiring callers to understand the nuance.
Contributor
There was a problem hiding this comment.
Also same nit from previous PR where I feel this is somewhat confusing right now:
async function getAuthHeaderOrThrow() { ... } // workspace token
async function getFirebaseHeaderOrThrow() { ... }just in the sense that the distinction is not conveyed super explicitly by way of variable/function names. Wish we could encapsulate the nuance in the auth modules somehow.
|
simula-r
added a commit
that referenced
this pull request
Jan 25, 2026
Add team workspace member management and invite system. - Add members panel with role management (owner/admin/member) and member removal - Add invite system with email invites, pending invite display, and revoke functionality - Add invite URL loading for accepting invites - Add subscription panel updates for member management - Add i18n translations for member and invite features (cherry picked from commit 4771565)
simula-r
added a commit
that referenced
this pull request
Jan 25, 2026
## Summary Backport of #8245 to cloud/1.37. Add team workspace member management and invite system. - Add members panel with role management (owner/admin/member) and member removal - Add invite system with email invites, pending invite display, and revoke functionality - Add invite URL loading for accepting invites - Add subscription panel updates for member management - Add i18n translations for member and invite features ## Conflict Resolution - `src/components/dialog/GlobalDialog.vue`: Added missing `DialogPassThroughOptions` import - `src/locales/en/main.json`: Kept "nightly" section from main (was present before PR) - `src/platform/cloud/subscription/utils/subscriptionCheckoutUtil.ts`: Deleted (file doesn't exist in cloud/1.37, only contains unrelated method rename) (cherry picked from commit 4771565) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8301-backport-cloud-1-37-Workspaces-4-members-invites-2f36d73d36508119a388dac9d290efbd) by [Unito](https://www.unito.io)
This was referenced Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add team workspace member management and invite system.
Changes
┆Issue is synchronized with this Notion page by Unito