hide "unload models" and "unload cache" menu entries on cloud #6879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
📝 WalkthroughWalkthroughThe Edit menu commands in the core menu configuration are now conditionally rendered based on deployment type. Memory unload commands are only included for non-cloud deployments, while the Refresh Node Definitions command is removed entirely. Changes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
Comment |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/23/2025, 10:39:48 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/23/2025, 10:28:55 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • 🟢 -25 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 941 kB (baseline 941 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.7 MB (baseline 5.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
DrJKL
approved these changes
Nov 24, 2025
DrJKL
reviewed
Nov 24, 2025
| 'Comfy.RefreshNodeDefinitions', | ||
| 'Comfy.Memory.UnloadModels', | ||
| 'Comfy.Memory.UnloadModelsAndExecutionCache' | ||
| ...(isCloud |
Contributor
There was a problem hiding this comment.
Should RefreshNodeDefinitions be gated too?
Contributor
Author
There was a problem hiding this comment.
There may be cases where it's desired in the immediate short-term e.g. load image node using an image uploaded in another load image node (maybe?).
snomiao
added a commit
that referenced
this pull request
Nov 25, 2025
Fixes the ReferenceError for __DISTRIBUTION__ when running i18n collection tests. Previously, Playwright's test runner would fail when importing code that uses Vite define variables (like __DISTRIBUTION__) because these variables are only replaced during Vite's build/dev process. Solution: - Created scripts/vite-define-shim.ts that defines all Vite define variables as global constants before tests run - Import the shim at the top of collect-i18n-general.ts - Also provides a minimal window shim for Node environment This allows the i18n collection process to import and evaluate coreMenuCommands which uses isCloud (which depends on __DISTRIBUTION__). Related to PR #6879 which added conditional menu commands based on distribution. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
christian-byrne
added
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides these features which the user does not need when on cloud.
┆Issue is synchronized with this Notion page by Unito