[chore] make experiment asset api setting hidden #5851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results⏰ Completed at: 09/29/2025, 11:12:48 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
AustinMroz
approved these changes
Sep 29, 2025
Collaborator
AustinMroz
left a comment
AustinMroz
left a comment
There was a problem hiding this comment.
I wish I had a better answer for the "how", but the code here is beneficial.
Even the ugly edge case of "how does a user disable a setting that doesn't exist?" is, at worst, more reports to track from if there is something strange happening here.
christian-byrne
approved these changes
Sep 29, 2025
AustinMroz
added
needs-backport
|
@arjansingh Backport to Please manually cherry-pick commit Conflicting files
|
1 similar comment
|
@arjansingh Backport to Please manually cherry-pick commit Conflicting files
|
AustinMroz
pushed a commit
that referenced
this pull request
Sep 30, 2025
Backport of #5851 to to `core/1.27`
AustinMroz
pushed a commit
that referenced
this pull request
Sep 30, 2025
Backport of #5851 to to `core/1.27`
webfiltered
pushed a commit
that referenced
this pull request
Sep 30, 2025
Backport of #5851 to to `core/1.27` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5861-backport-1-27-chore-make-experiment-asset-api-setting-hidden-27e6d73d3650819ea7c0fc0d48a393ee) by [Unito](https://www.unito.io) Co-authored-by: Arjan Singh <1598641+arjansingh@users.noreply.github.com>
christian-byrne
pushed a commit
that referenced
this pull request
Oct 6, 2025
## Summary This way no one can accidentally enable it when they are messing around. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5851-chore-make-experiment-asset-api-setting-hidden-27d6d73d36508113a6c1e41a764325f3) by [Unito](https://www.unito.io)
arjansingh
added a commit
that referenced
this pull request
Oct 7, 2025
## Summary This way no one can accidentally enable it when they are messing around. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5851-chore-make-experiment-asset-api-setting-hidden-27d6d73d36508113a6c1e41a764325f3) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This way no one can accidentally enable it when they are messing around.
┆Issue is synchronized with this Notion page by Unito