fix: don't immediately close missing nodes dialog if manager is disabled #5647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
added
the
needs-backport
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/19/2025, 12:54:14 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
viva-jinyi
approved these changes
Sep 19, 2025
christian-byrne
deleted the
manager/fix/dont-close-dialog-if-disabled
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
…led (#5647) If manager is disabled, it assumed all missing nodes are installed and immediately closes the missing nodes warning when loading a workflow with missing nodes. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5647-fix-don-t-immediately-close-missing-nodes-dialog-if-manager-is-disabled-2736d73d36508199a50bca2026528ab6) by [Unito](https://www.unito.io)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
…led (#5647) If manager is disabled, it assumed all missing nodes are installed and immediately closes the missing nodes warning when loading a workflow with missing nodes. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5647-fix-don-t-immediately-close-missing-nodes-dialog-if-manager-is-disabled-2736d73d36508199a50bca2026528ab6) by [Unito](https://www.unito.io)
Member
|
@christian-byrne Successfully backported to #5648 |
Member
|
@christian-byrne Successfully backported to #5649 |
christian-byrne
added a commit
that referenced
this pull request
Sep 19, 2025
…manager is disabled (#5649) Backport of #5647 to `core/1.27` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5649-backport-1-27-fix-don-t-immediately-close-missing-nodes-dialog-if-manager-is-disabled-2736d73d3650813681a7d1983f8ccf96) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
christian-byrne
added a commit
that referenced
this pull request
Sep 19, 2025
…manager is disabled (#5648) Backport of #5647 to `core/1.26` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5648-backport-1-26-fix-don-t-immediately-close-missing-nodes-dialog-if-manager-is-disabled-2736d73d3650815dba5ac53f6d4578b5) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Merged
christian-byrne
added a commit
that referenced
this pull request
Sep 19, 2025
## What's Changed ### 🐛 Bug Fixes - Fix: don't immediately close missing nodes dialog if manager is disabled (#5647) **Full Changelog**: v1.26.12...v1.26.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If manager is disabled, it assumed all missing nodes are installed and immediately closes the missing nodes warning when loading a workflow with missing nodes.
┆Issue is synchronized with this Notion page by Unito