Skip to content

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Sep 10, 2025

Summary

Pricing for new upcoming API node. Changes should be back-ported for today's release, afaik.

Number of output images can be controlled by prompt, in cases where we do not know the exact price we display maximum price.

Screenshots (if applicable)

simplescreenrecorder-2025-09-10_20.04.44.mp4

┆Issue is synchronized with this Notion page by Unito

@bigcat88 bigcat88 requested review from a team as code owners September 10, 2025 17:08
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

🎭 Playwright Test Results

Tests completed successfully!

⏰ Completed at: 09/10/2025, 05:19:00 PM UTC

📊 Test Reports by Browser


🎉 Click on the links above to view detailed test results for each browser configuration.

@benceruleanlu benceruleanlu added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.26 labels Sep 10, 2025
@bigcat88
Copy link
Contributor Author

can we merge this?

Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise 👍🏻

if (maxImages === 1) {
return '$0.03/Run'
}
const cost = (0.03 * maxImages).toFixed(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Float math. A dangerous game.

Completely optional, but how would you feel about changing it to an int of cents when multiplying then dividing by 100 at the end for formatting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with changing that, but I am already afk for today. :(

I took this code somewhere from this file

@christian-byrne christian-byrne merged commit 2e64c64 into main Sep 11, 2025
33 checks passed
@christian-byrne christian-byrne deleted the feat/api-nodes/pricing/ByteDanceSeedream4 branch September 11, 2025 00:46
github-actions bot pushed a commit that referenced this pull request Sep 11, 2025
@comfy-pr-bot
Copy link
Member

@bigcat88 Successfully backported to #5483

benceruleanlu pushed a commit that referenced this pull request Sep 11, 2025
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
arjansingh pushed a commit that referenced this pull request Sep 11, 2025
snomiao pushed a commit that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.26 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants