[fix] Add missing deployment-info artifact creation in playwright workflows #5334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines pr-playwright-deploy.yaml and pr-playwright-comment.yaml into a single workflow to ensure proper dependency ordering. The comment job now waits for deployments to complete before generating comments with deployment URLs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…kflows - Capture wrangler deployment URL output and save to GitHub outputs - Create deployment-info artifacts with test results and deployment URLs - Add test exit code tracking in test-ui.yaml workflow - Add PR number logging for debugging - Improve URL extraction with multiple patterns and fallback This fixes the issue where PR comments were missing deployment links because the deployment-info artifacts were never created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where PR comments were missing deployment links because the deployment-info artifacts were never created.
Problem
After PR #5298, the playwright deploy workflow was commenting on PRs but with no deployment links. The
comment-tests-completedjob was trying to downloaddeployment-info-*artifacts that didn't exist.Solution
Test Plan
This PR will test itself - the CI/CD pipeline should now properly generate comments with deployment URLs for each browser's test report.
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito