Fix Chromatic build failure by updating build-storybook script #5276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace nx build-storybook with direct storybook build command to properly forward --output-dir argument from Chromatic deployment. Fixes invalid Storybook build issue where static files were empty due to Nx not passing through command-line arguments to the underlying Storybook build command. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/31/2025, 04:31:36 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 08/31/2025, 04:09:09 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
snomiao
force-pushed
the
version-bump-1.26.8--sno-debug
branch
2 times, most recently
from
92a810b to
a988461
Compare
dosubot
bot
added
the
size:XS
snomiao
force-pushed
the
version-bump-1.26.8--sno-debug
branch
from
5bce30e to
06c1014
Compare
christian-byrne
approved these changes
Aug 31, 2025
snomiao
added a commit
that referenced
this pull request
Aug 31, 2025
* [release] Increment version to 1.26.8 * [fix] Fix Chromatic build failure by updating build-storybook script Replace nx build-storybook with direct storybook build command to properly forward --output-dir argument from Chromatic deployment. Fixes invalid Storybook build issue where static files were empty due to Nx not passing through command-line arguments to the underlying Storybook build command. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Change version to 0.7 for testing purposes * chore(package.json): update version from 0.7 to 1.26.7 to reflect new release --------- Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nx build-storybookwith directstorybook buildcommand to properly forward --output-dir argumentProblem
The Chromatic deployment was failing because the Nx wrapper for
build-storybookwasn't forwarding the--output-dirargument that Chromatic passes. This caused static files (HTML, CSS, fonts) to be empty (0 bytes), making Chromatic reject the build as invalid.Solution
Changed package.json script from
nx build-storybooktostorybook buildto allow proper argument forwarding.Test plan
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito