fix: Ensure logout clears both Firebase auth and API key #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging out via the avatar dropdown, the logout function was only clearing Firebase authentication but not the stored API key. This could leave users partially authenticated with their API key still active. Updated CurrentUserPopover to use handleSignOut from useCurrentUser composable, which properly handles both authentication methods: - Clears API key if logged in with API key - Signs out Firebase if logged in with Firebase This ensures complete logout regardless of authentication method. Fixes #5261 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/31/2025, 12:49:43 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
🎨 Storybook Build Status⏳ Build is starting... ⏰ Started at: 08/31/2025, 12:26:17 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
🎨 Storybook Build Status⏳ Build is starting... ⏰ Started at: 08/31/2025, 12:22:57 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
Updated test mocks to include handleSignOut from useCurrentUser composable and adjusted test expectations to verify handleSignOut is called instead of the direct logout method. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
size:S
snomiao
pushed a commit
that referenced
this pull request
Aug 31, 2025
* fix: Ensure logout clears both Firebase auth and API key When logging out via the avatar dropdown, the logout function was only clearing Firebase authentication but not the stored API key. This could leave users partially authenticated with their API key still active. Updated CurrentUserPopover to use handleSignOut from useCurrentUser composable, which properly handles both authentication methods: - Clears API key if logged in with API key - Signs out Firebase if logged in with Firebase This ensures complete logout regardless of authentication method. Fixes #5261 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * test: Update CurrentUserPopover tests to match new logout implementation Updated test mocks to include handleSignOut from useCurrentUser composable and adjusted test expectations to verify handleSignOut is called instead of the direct logout method. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CurrentUserPopovercomponent to use the correct logout handlerProblem
When logging out via the avatar dropdown in the top right, the logout function was only clearing Firebase authentication but not the stored API key. This could leave users partially authenticated with their API key still active after appearing to log out.
Solution
Updated
CurrentUserPopover.vueto usehandleSignOutfrom theuseCurrentUsercomposable instead of directly callingauthActions.logout(). ThehandleSignOutmethod properly handles both authentication methods:This ensures complete logout regardless of authentication method.
Console commands to verify auth state:
Fixes #5261
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito