Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Aug 30, 2025

Summary

Enhanced the Storybook comment workflow to restrict execution to version-bump branches and properly handle different build statuses.

Changes

  • What: Updated pr-storybook-comment workflow to handle skipped and cancelled build statuses with appropriate messaging and icons
  • Breaking: None
  • Dependencies: None

Review Focus

The workflow now:

  1. Only runs on branches starting with version-bump- to avoid unnecessary comments on regular PRs
  2. Properly handles 4 different build conclusions: success (✅), skipped (⏭️), cancelled (🚫), and failed (❌)
  3. Provides clear, status-specific messages for each conclusion type

This improves the user experience by providing clearer feedback about the Chromatic/Storybook build status and reduces noise on non-version-bump PRs.

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

- Add condition to only run on version-bump branches
- Handle additional build statuses (skipped, cancelled) with appropriate icons and messages
- Improve readability by breaking long conditionals across multiple lines

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@benceruleanlu benceruleanlu requested a review from a team as a code owner August 30, 2025 23:28
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 30, 2025
@github-actions
Copy link

github-actions bot commented Aug 30, 2025

🎨 Storybook Build Status

comfy-loading-gif Build is starting...

⏰ Started at: 08/31/2025, 05:42:06 PM UTC

🚀 Building Storybook

  • 📦 Installing dependencies...
  • 🔧 Building Storybook components...
  • 🎨 Running Chromatic visual tests...

⏱️ Please wait while the Storybook build is in progress...

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

🎭 Playwright Test Results

comfy-loading-gif Tests are starting...

⏰ Started at: UTC

🚀 Running Tests

  • 🧪 chromium: Running tests...
  • 🧪 chromium-0.5x: Running tests...
  • 🧪 chromium-2x: Running tests...
  • 🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running across all browsers...

Copy link
Member

@snomiao snomiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@snomiao
Copy link
Member

snomiao commented Aug 31, 2025

note for other reviewers:

image

this is outdated result, because:

This workflow will enable after merge to main

cc @christian-byrne

@benceruleanlu benceruleanlu merged commit b99e451 into main Aug 31, 2025
7 checks passed
@benceruleanlu benceruleanlu deleted the fix/storybook-comment-workflow-status-handling branch August 31, 2025 17:42
@benceruleanlu benceruleanlu mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CI/CD size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants