Fix broken links on bypass prior to reroute #5237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/28/2025, 05:35:55 AM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
DrJKL
approved these changes
Aug 28, 2025
christian-byrne
added
the
claude-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4864 added more nuanced handling for links of bypassed nodes. Unfortunately, it introduced an edge case with a bypassed node prior to a legacy reroute. Legacy reroutes report their input type as
*. This triggers a short circuit in#getBypassSlotIndex. When the determined bypassed connection does not match the actual type requirements on the other side of the reroute, this results in a type mismatch on execution.While there is likely merit to further consideration upon the value of the short circuit, this pull request is targeted to minimize unecessary changes in functionality by providing a route for virtual nodes, like reroutes, to pass their actual required input type.
Resolves comfyanonymous/ComfyUI#9567
Likely also related to 4839
┆Issue is synchronized with this Notion page by Unito