[feat] Add account deletion functionality to UserPanel component #5216
Conversation
yoland68
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/29/2025, 10:29:27 PM UTC 📊 Test Reports by Browser
🎉 Your tests are passing across all browsers! |
dosubot
bot
added
size:M
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
The code looks good, but can we make the button bigger?
| /> | ||
| <Button | ||
| v-if="!isApiKeyLogin" | ||
| class="w-32" |
There was a problem hiding this comment.
w-32 looks a little narrow, since it's causing the text to wrap. Could we do a max-w instead? Also I'm not sure what it'll look like post-i18n.
|
Ugh, such nit, this ain't google, just gonna land it |
DrJKL
force-pushed
the
yo-delete-account
branch
from
052497a to
968ac8d
Compare
|
This should definitely be going through sign-out code paths to clear auth persistence and reset UI states. |
The only thing seem to be // useCurrentUser.ts
const handleSignOut = async () => {
if (isApiKeyLogin.value) {
await apiKeyStore.clearStoredApiKey()
} else {
await commandStore.execute('Comfy.User.SignOut')
}
} |
|
deleteAccount handles signout for firebase |
Okay sounds good |
- Implemented a new button for deleting user accounts in UserPanel.vue - Added confirmation dialog for account deletion using dialogService - Integrated deleteAccount action in useFirebaseAuthActions - Updated en files to include new translation keys for account deletion
DrJKL
force-pushed
the
yo-delete-account
branch
from
968ac8d to
4fc6722
Compare
|
And Supabase? |
Summary
Add account deletion functionality to UserPanel component
Changes
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito