Skip to content

[backport 1.25] fix: Handle missing subgraph inputs gracefully during workflow import #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[backport 1.25] fix: Handle missing subgraph inputs gracefully during workflow import #4986

merged 1 commit into from
Aug 15, 2025

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Aug 14, 2025 •
edited by sync-by-unito bot
Loading

Backport of #4985 to core/1.25

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne @github-actions
fix: Handle missing subgraph inputs gracefully during workflow import (…
07d01fc 
…#4985)

When loading workflows, SubgraphNode would throw an error if an input
exists in the serialized data that doesn't exist in the current subgraph
definition. This can happen when:
- Subgraph definitions change after workflows are saved
- Workflows are shared between users with different subgraph versions
- Dynamic inputs were added that don't exist in the base definition

This change converts the hard error to a warning and continues processing,
allowing workflows to load even with mismatched subgraph configurations.

Fixes #4905
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 14, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner August 14, 2025 21:32
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 14, 2025
@comfy-pr-bot comfy-pr-bot mentioned this pull request Aug 14, 2025
Merged
@github-actions
Copy link

github-actions bot commented Aug 14, 2025 •
edited
Loading

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@christian-byrne christian-byrne merged commit 6265dfa into core/1.25 Aug 15, 2025
18 checks passed
@christian-byrne christian-byrne deleted the backport-4985-to-1.25 branch August 15, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comfy-pr-bot @christian-byrne