Skip to content

[fix] Make minimap reactive to subgraph context changes #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jul 30, 2025

Fixes minimap not updating when working inside subgraphs by replacing non-reactive graph references with proper Vue reactivity that watches for subgraph context changes.

┆Issue is synchronized with this Notion page by Unito

Previously, the minimap would not update when navigating inside subgraphs because it was using non-reactive graph references that always pointed to the main graph. This fix introduces proper reactivity by watching workflowStore.activeSubgraph and updating the graph reference when the subgraph context changes.
@christian-byrne christian-byrne requested a review from a team as a code owner July 30, 2025 09:51
Copy link

github-actions bot commented Jul 30, 2025

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

Added missing mocks for app import and workflowStore to fix test failures
caused by the new reactive subgraph functionality. Updated test expectation
for empty graph rendering to align with the new reactive behavior.
@christian-byrne christian-byrne requested a review from a team as a code owner July 30, 2025 10:26
@christian-byrne christian-byrne merged commit 2c84ecb into main Jul 30, 2025
15 checks passed
@christian-byrne christian-byrne deleted the fix/minimap-subgraph-reactivity branch July 30, 2025 17:41
@christian-byrne christian-byrne added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:minimap needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant