Skip to content

[ci] Enable CI tests for all feature branch PRs #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jul 30, 2025

Summary

This PR updates our GitHub Actions workflows to run CI tests on all pull requests (except obvious WIP branches), not just PRs targeting specific branches.

Problem

Currently, CI only runs on PRs targeting main, master, dev*, core/, or desktop/ branches. This means:

  • Collaborators working on feature branches (like manager/refactor/*) don't get test feedback
  • Issues are only discovered when merging to main branches
  • No early validation of code quality

Solution

Changed all test workflows to use branches-ignore pattern instead of explicit branch allowlist:

  • Runs CI on ALL pull requests by default
  • Excludes only: wip/, draft/, temp/* branches
  • Gives immediate test feedback to all contributors

Changes

  • Updated test-ui.yaml (Playwright tests)
  • Updated vitest.yaml (Unit/Component tests)
  • Updated eslint.yaml (Linting)

This ensures collaborators get test suite feedback on feature branches while still allowing them to skip CI for work-in-progress branches.

┆Issue is synchronized with this Notion page by Unito

- Update test-ui.yaml, vitest.yaml, eslint.yaml, and format.yaml workflows
- Change from explicit branch allowlist to branches-ignore pattern
- Exclude only wip/*, draft/*, and temp/* branches from CI
- Ensures collaborators get test feedback on feature branches
- All required checks for claude-pr-review will now run
@christian-byrne christian-byrne force-pushed the ci/enable-all-pr-tests branch from 8e00268 to 0273093 Compare July 30, 2025 08:24
@christian-byrne christian-byrne merged commit 5c71854 into main Jul 30, 2025
11 checks passed
@christian-byrne christian-byrne deleted the ci/enable-all-pr-tests branch July 30, 2025 08:27
@christian-byrne christian-byrne mentioned this pull request Jul 31, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant