[fix] Fix "Require confirmation before clearing workflow" setting not working #4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CoreCommands This fixes the "Require confirmation when clearing workflow" setting not working with the new V3 menu system, breadcrumb dropdown, and keybindings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
christian-byrne
changed the title
christian-byrne
changed the title
|
A Playwright test case now fails because it was using the ClearWorkflow command and not expecting the confirm dialog: |
This was referenced Jul 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the "Require confirmation when clearing workflow" setting (
Comfy.ConfirmClear) not working with:The setting only worked correctly in the old UI menu.
Root Cause Analysis
The Original Issue: A typo in
src/composables/useCoreCommands.tsline 171Why TypeScript Didn't Catch It: Instead of fixing the typo in the code, someone added the typo as a valid setting to
src/schemas/apiSchema.tsChanges
Fixed the typo in
src/composables/useCoreCommands.ts:'Comfy.ComfirmClear'→'Comfy.ConfirmClear'Removed the duplicate typo setting from
src/schemas/apiSchema.ts:'Comfy.ComfirmClear': z.boolean(),'Comfy.ConfirmClear': z.boolean(),Fixes #4585
┆Issue is synchronized with this Notion page by Unito