Skip to content

fix: node migration TypeError #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

viva-jinyi
Copy link
Collaborator

@viva-jinyi viva-jinyi commented Jun 24, 2025

Context
Slack Threads

Added a guard clause for cases where a custom node defines RETURN_TYPES = ("BOOLEAN") instead of a proper tuple like ("BOOLEAN",).
Without the trailing comma, it’s interpreted as a string rather than an array, which causes issues on the frontend.
This fix ensures the frontend can handle such cases more gracefully.

┆Issue is synchronized with this Notion page by Unito

@viva-jinyi viva-jinyi self-assigned this Jun 24, 2025
@viva-jinyi viva-jinyi marked this pull request as ready for review June 24, 2025 10:57
@viva-jinyi viva-jinyi requested a review from a team as a code owner June 24, 2025 10:57
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my eyes, it looks like this will now silently discard the error instead of throwing - but without any indication as to why nothing happened, or how to fix it. I think we should instead do a nested if instead of && - and probably log the error condition.

@viva-jinyi
Copy link
Collaborator Author

viva-jinyi commented Jun 25, 2025

@webfiltered Thank you for pointing out. I'll make the changes accordingly.

@viva-jinyi viva-jinyi requested a review from webfiltered June 25, 2025 01:39
@viva-jinyi viva-jinyi force-pushed the fix/custom-node-return-type branch from 62c42d4 to 8b110ce Compare June 25, 2025 07:39
@webfiltered
Copy link
Contributor

Awesome - thank you!

@webfiltered webfiltered merged commit e17ca7c into Comfy-Org:main Jun 25, 2025
10 checks passed
@viva-jinyi viva-jinyi deleted the fix/custom-node-return-type branch June 26, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants