Merged
Conversation
Member
Author
|
AFAIK the APP ID and Search-specific key can both be public facing, could we just add it plaintext to .env_example? |
Contributor
Seems fine to me. Will make one less hurdle when onboard new people or for OS dev. |
webfiltered
approved these changes
Jun 5, 2025
webfiltered
deleted the
codex/add-algolia_app_id-and-algolia_api_key-to-.env_example
branch
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run formatnpm run lintnpm run typechecknpm run test:unitnpm run test:componentnpm run test:browser(fails: Set TEST_COMFYUI_DIR in .env to prevent user data from being overwritten)https://chatgpt.com/codex/tasks/task_e_68404795db708330ad581eca1b96b1d6
┆Issue is synchronized with this Notion page by Unito