[feat] Add workflow to generate ComfyUI-Manager types from OpenAPI#4072
Merged
christian-byrne merged 3 commits intomainfrom Jun 4, 2025
Merged
[feat] Add workflow to generate ComfyUI-Manager types from OpenAPI#4072christian-byrne merged 3 commits intomainfrom
christian-byrne merged 3 commits intomainfrom
Conversation
Implements automated type generation from ComfyUI-Manager's openapi.yaml to replace manually maintained API types and ensure consistency with upstream changes.
webfiltered
reviewed
Jun 4, 2025
- Uses ComfyUI_frontend_setup_action@v2.3 for consistent setup - Adopts same git config and branch handling as browser expectations workflow - Works within ComfyUI_frontend directory structure for proper paths
Contributor
Author
|
Going to change to follow format of https://github.com/Comfy-Org/ComfyUI_frontend/blob/51ce99d3752f15551e2091f5bf45c9aa76b32365/.github/workflows/update-registry-types.yaml |
- Uses same setup pattern: checkout, Node.js setup, npm ci - Generates types in main repo directory structure - Checks for changes before creating PR - Uses peter-evans/create-pull-request for automated PR creation - Includes proper permissions for contents and pull-requests - Removes incorrect ComfyUI_frontend_setup_action usage
Contributor
Author
|
Going to merge so I can start testing it and seeing and see how difficult it will be to fully replace manual types with the generated ones. |
Contributor
|
Sounds good! We should not worry about merging new dispatch workflows. imo In the event that it has to be left incomplete (e.g. to focus on another project), we should create a tracking issue, or just revert until ready. |
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitHub workflow to automatically generate TypeScript types from ComfyUI-Manager's OpenAPI specification, replacing manually maintained API types and ensuring consistency with upstream API changes.
Fixes #4069
┆Issue is synchronized with this Notion page by Unito