[fix] Remove dynamic import timing issue causing Playwright test flakiness#4031
Merged
webfiltered merged 1 commit intomainfrom May 31, 2025
Merged
Conversation
Replace dynamic import with static import in handleFile method to eliminate race condition causing Playwright test flakiness. The dynamic import introduced asynchronous behavior that created timing issues in tests expecting immediate file processing completion. Fixes #3955 test flakiness
Contributor
Author
|
Test report: |
webfiltered
approved these changes
May 31, 2025
This was referenced Jun 1, 2025
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deferred timing condition introduced in PR #3955 that was causing multiple Playwright tests to become flaky.
Problem:
PR #3955 refactored file handling by introducing a dynamic import in the
handleFilemethod:Fixes #4029.
┆Issue is synchronized with this Notion page by Unito