[bugfix] Filter model metadata by current widget selection#4021
Merged
webfiltered merged 8 commits intomainfrom Jun 1, 2025
Merged
[bugfix] Filter model metadata by current widget selection#4021webfiltered merged 8 commits intomainfrom
webfiltered merged 8 commits intomainfrom
Conversation
Only include model metadata for models actually selected in node widgets. This prevents false positives in the missing models dialog when nodes contain outdated metadata from previously selected models. Fixes #3664
webfiltered
reviewed
May 30, 2025
Contributor
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
This is really just one suggested change.
"Simplify code using idiomatic undefined"
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
Add non-null assertions for test cases expecting arrays and correct test expectations for cases that should return undefined.
Contributor
Author
|
Changes:
|
webfiltered
approved these changes
Jun 1, 2025
Contributor
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
Will merge into 1.22
1 task
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
…#4021) Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter models in workflow metadata to only include those actually selected in node widgets. Prevents false positives in the missing models dialog when nodes contain outdated metadata.
Fixes #3664
┆Issue is synchronized with this Notion page by Unito