Skip to content

[API Node] Add localizations for template workflow descriptions#3769

Merged
christian-byrne merged 6 commits intomainfrom
translate-template-descripts
May 5, 2025
Merged

[API Node] Add localizations for template workflow descriptions#3769
christian-byrne merged 6 commits intomainfrom
translate-template-descripts

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented May 5, 2025

Localize the tempalate card descriptions, in addition to the names.

In the future, the process of adding names and descriptions to localizations will be automated, but for the short-term it can just be done manually like this.

The descriptions for the API node tempalates are WIP and subject to change in near future.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label May 5, 2025
Copy link
Contributor

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n also needed here for list view

<span :title="slotProps.data.description.replace(/[-_]/g, ' ')">
{{ slotProps.data.description.replace(/[-_]/g, ' ') }}
</span>

@christian-byrne
Copy link
Contributor Author

Made changes:

  • Set localization in the store's computed templates property using dedicated localized[FieldName] fields -- better than overwriting as it allows accessing via original keys
  • Use the localized fields in both Card and List views of the templates dialog
  • Fix the keys that were added mistakenly with dots in the names
  • Adjust title title height to precise value such that other languages do not have part of the characters in second row truncated
localize-templates-fully.mp4

@christian-byrne christian-byrne merged commit c24472a into main May 5, 2025
10 checks passed
@christian-byrne christian-byrne deleted the translate-template-descripts branch May 5, 2025 19:53
christian-byrne added a commit that referenced this pull request May 9, 2025
Co-authored-by: github-actions <github-actions@github.com>
christian-byrne added a commit that referenced this pull request May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants