[API Node] Sort API templates by localized display name#3765
Merged
christian-byrne merged 2 commits intomainfrom May 5, 2025
Merged
[API Node] Sort API templates by localized display name#3765christian-byrne merged 2 commits intomainfrom
christian-byrne merged 2 commits intomainfrom
Conversation
christian-byrne
requested review from
a team,
DorotaLuna,
KarryCharon,
Yorha4D and
shinshin86
as code owners
huchenlei
approved these changes
May 5, 2025
christian-byrne
added
the
needs-backport
christian-byrne
added a commit
that referenced
this pull request
May 5, 2025
Co-authored-by: github-actions <github-actions@github.com>
huchenlei
pushed a commit
that referenced
this pull request
May 6, 2025
Co-authored-by: github-actions <github-actions@github.com>
christian-byrne
added a commit
that referenced
this pull request
May 9, 2025
Co-authored-by: github-actions <github-actions@github.com>
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, API templates are sorted alphabetically to prevent favoritism/bias. However, they need to sorted by display name rather than key name. Otherwise, there could be discrepancies between display name sorting and keyname sorting result -- and the fact that they are alphabetically sorted would no longer come through in the UI.
┆Issue is synchronized with this Notion page by Unito