Conversation
huchenlei
suggested changes
May 2, 2025
Contributor
huchenlei
left a comment
There was a problem hiding this comment.
There are various other places where we just Avatar, Ideally we wrap it in a new component so the fallback logic can be reused.
Contributor
Author
Good point. |
e264a6c to
cb3d052
Compare
Contributor
Author
|
Changes:
|
huchenlei
suggested changes
May 6, 2025
Contributor
huchenlei
left a comment
There was a problem hiding this comment.
Can
ComfyUI_frontend/src/components/topbar/CurrentUserPopover.vue
Lines 7 to 14 in 926278e
cb3d052 to
ad9b721
Compare
Contributor
Author
|
Changes:
|
huchenlei
approved these changes
May 7, 2025
christian-byrne
added a commit
that referenced
this pull request
May 9, 2025
Co-authored-by: github-actions <github-actions@github.com>
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Avatarcomponent emits error, use icon as fallback.Prevents this scenario:
Additionally, adds translation for aria label.