Skip to content

[API Node] Conditional signup render#3653

Merged
huchenlei merged 5 commits intomainfrom
api-nodes/conditional-signup
Apr 28, 2025
Merged

[API Node] Conditional signup render#3653
huchenlei merged 5 commits intomainfrom
api-nodes/conditional-signup

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Apr 27, 2025

Adds condition to rendering of signup component.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner April 27, 2025 02:45
Copy link
Contributor

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in code what are disabled for China users? I also think we should communicate more explicitly to China users why we disabled some features for them.

@christian-byrne
Copy link
Contributor Author

Can you explain in code what are disabled for China users?

You mean via comments?

I also think we should communicate more explicitly to China users why we disabled some features for them.

Any suggestions for what to say?

@huchenlei
Copy link
Contributor

You mean via comments?

Comment should explain what is disabled for the Chinese user. According to the code I think you disabled the whole signup option for users in China.

Any suggestions for what to say?

Probably something like:

In accordance with local regulatory requirements, our services are currently unavailable to users located in mainland China.

@christian-byrne
Copy link
Contributor Author

christian-byrne commented Apr 28, 2025

I added a notification. I will ask for assistance in assuring the translation is accurate after it is generated.

Workspace 2_005

Re: commenting the code:

It says: <SignUpForm v-else-if="!userIsInChina" => "Sign up form renders if not user is in China." This is close to written English language, which I feel is a good indication of self-documenting code.

@huchenlei huchenlei force-pushed the api-nodes/conditional-signup branch from f5377f5 to 3acfd81 Compare April 28, 2025 01:41
layout="horizontal"
class="my-8"
>
<Divider align="center" layout="horizontal" class="my-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can always show the divider here, tie it to the email signin/up form state is probably not so necessary.

@huchenlei huchenlei merged commit 96d954c into main Apr 28, 2025
10 checks passed
@huchenlei huchenlei deleted the api-nodes/conditional-signup branch April 28, 2025 01:47
christian-byrne added a commit that referenced this pull request May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Chenlei Hu <hcl@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants