Skip to content

[Cleanup] Remove unnecessary null check on auth#3610

Merged
huchenlei merged 2 commits intomainfrom
auth_fix
Apr 24, 2025
Merged

[Cleanup] Remove unnecessary null check on auth#3610
huchenlei merged 2 commits intomainfrom
auth_fix

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Apr 24, 2025

From useFirebaseAuth docs:

Retrieves the Firebase Auth instance. Returns null on the server.
When using this function on the client in TypeScript, you can force the type with `useFirebaseAuth()!

We can skip the null value check as the code runs in client not server.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested review from a team as code owners April 24, 2025 21:16
@huchenlei huchenlei merged commit 0ed29a1 into main Apr 24, 2025
8 checks passed
@huchenlei huchenlei deleted the auth_fix branch April 24, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant